Rally crashes with AttributeError when using urllib3 < 1.13

Bug #1573650 reported by Ihar Hrachyshka on 2016-04-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Rally
Undecided
Ihar Hrachyshka

Bug Description

http://logs.openstack.org/69/285369/4/check/gate-rally-dsvm-neutron-neutron/c18f3b0/logs/devstacklog.txt.gz#_2016-04-22_13_51_32_955

2016-04-22 13:51:32.129 | ++ rally-manage --config-file /etc/rally/rally.conf db recreate
2016-04-22 13:51:32.955 | 2016-04-22 13:51:32.954 15699 CRITICAL rally [-] AttributeError: 'module' object has no attribute 'SNIMissingWarning'
2016-04-22 13:51:32.955 | 2016-04-22 13:51:32.954 15699 ERROR rally Traceback (most recent call last):
2016-04-22 13:51:32.955 | 2016-04-22 13:51:32.954 15699 ERROR rally File "/usr/local/bin/rally-manage", line 10, in <module>
2016-04-22 13:51:32.955 | 2016-04-22 13:51:32.954 15699 ERROR rally sys.exit(main())
2016-04-22 13:51:32.955 | 2016-04-22 13:51:32.954 15699 ERROR rally File "/opt/stack/new/rally/rally/cli/manage.py", line 81, in main
2016-04-22 13:51:32.955 | 2016-04-22 13:51:32.954 15699 ERROR rally return cliutils.run(sys.argv, categories)
2016-04-22 13:51:32.955 | 2016-04-22 13:51:32.954 15699 ERROR rally File "/opt/stack/new/rally/rally/cli/cliutils.py", line 509, in run
2016-04-22 13:51:32.955 | 2016-04-22 13:51:32.954 15699 ERROR rally urllib3.disable_warnings(urllib3.exceptions.SNIMissingWarning)
2016-04-22 13:51:32.955 | 2016-04-22 13:51:32.954 15699 ERROR rally AttributeError: 'module' object has no attribute 'SNIMissingWarning'
2016-04-22 13:51:32.955 | 2016-04-22 13:51:32.954 15699 ERROR rally

Changed in rally:
assignee: nobody → Ihar Hrachyshka (ihar-hrachyshka)

Fix proposed to branch: master
Review: https://review.openstack.org/309455

Changed in rally:
status: New → In Progress

Reviewed: https://review.openstack.org/309455
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=53ad2105a960805021604dd355b30cd4bddd41c4
Submitter: Jenkins
Branch: master

commit 53ad2105a960805021604dd355b30cd4bddd41c4
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Apr 22 16:48:56 2016 +0200

    disable urllib3 warnings only if the library provide them

    SNIMissingWarning was introduced in urllib3 in 1.13.

    When using rally with an older version of urllib3 (f.e. as used in
    liberty, urllib3>=1.8.3), the SNIMissingWarning may be not present, in
    which case the code will crash with AttributeError.

    So first check whether the warning is known to the urllib3 library being
    used with rally before trying to disable it.

    Change-Id: Idcdc7b43a032212064c4ed2e1a69b67656bf801c
    Closes-Bug: #1573650

Changed in rally:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers