[CleanUp] CleanUp Error saying- "Router could not be found" in network context

[Piyush]

When using network context, the cleanup throws error saying "Router Not found"

[root@piyush-104 ~]# cat sample_json_network.json
{
    "NeutronNetworks.create_and_delete_routers": [
        {
            "args": {
                "network_create_args": {},
                "subnet_create_args": {},
                "subnet_cidr_start": "1.1.0.0/30",
                "subnets_per_network": 1,
                "router_create_args": {}
            },
            "runner": {
                "type": "constant",
                "times": 1,
                "concurrency": 1
            },
            "context":{
                "network": {}
            }
        }
    ]
}

Error Trace can be found at- http://paste.openstack.org/show/494239/

Can also be seen in gates jobs-
http://logs.openstack.org/04/301804/10/check/gate-rally-dsvm-neutron-rally/cb93c35/console.html

Reason-
The user cleanup ( https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/cleanup/user.py#L46-52) deletes all the Neutron resources created in the network context (https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/network/networks.py#L77-88)

During cleanup() call for network context (https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/network/networks.py#L96), the entries are STILL there in the JSON (https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/network/networks.py#L88), but the resources have already been cleaned up during user cleanup.

[root@piyush-104 ~]# rally --version
0.3.4~dev131

[Piyush (pirsriva)]

Full debug logs for reference

[SHI Peiqi (uestc-shi)]

I am sorry, I made a mistake, you reported earlier than me. But if you dont mind, I assigne it to me, because I am close to fix it. Thank you :)

[Piyush (pirsriva)]

Hi,

No problem.
You go ahead with your solution if you are close to fixing it. :)

Thanks and regards,
Piyush

On Sun, May 15, 2016 at 10:01 AM, SHI Peiqi <email address hidden>
wrote:

> I am sorry, I made a mistake, you reported earlier than me. But if you
> dont mind, I assigne it to me, because I am close to fix it. Thank you
> :)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1570920
>
> Title:
> [CleanUp] CleanUp Error saying- "Router could not be found" in network
> context
>
> Status in Rally:
> New
>
> Bug description:
> When using network context, the cleanup throws error saying "Router
> Not found"
>
> [root@piyush-104 ~]# cat sample_json_network.json
> {
> "NeutronNetworks.create_and_delete_routers": [
> {
> "args": {
> "network_create_args": {},
> "subnet_create_args": {},
> "subnet_cidr_start": "1.1.0.0/30",
> "subnets_per_network": 1,
> "router_create_args": {}
> },
> "runner": {
> "type": "constant",
> "times": 1,
> "concurrency": 1
> },
> "context":{
> "network": {}
> }
> }
> ]
> }
>
> Error Trace can be found at- http://paste.openstack.org/show/494239/
>
> Can also be seen in gates jobs-
>
> http://logs.openstack.org/04/301804/10/check/gate-rally-dsvm-neutron-rally/cb93c35/console.html
>
> Reason-
> The user cleanup (
> https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/cleanup/user.py#L46-52)
> deletes all the Neutron resources created in the network context (
> https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/network/networks.py#L77-88
> )
>
> During cleanup() call for network context
> (
> https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/network/networks.py#L96
> ),
> the entries are STILL there in the JSON
> (
> https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/network/networks.py#L88
> ),
> but the resources have already been cleaned up during user cleanup.
>
> [root@piyush-104 ~]# rally --version
> 0.3.4~dev131
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/rally/+bug/1570920/+subscriptions
>

[Boris Pavlovic (boris-42)]

Shi,

could you share some early version of fix?

I don't see easy way to fix without refactoring of cleanup mechanism that is done by spierre

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/319913

[OpenStack Infra (hudson-openstack)]

Change abandoned by SHIPeiqi (<email address hidden>) on branch: master
Review: https://review.openstack.org/319913

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/321476