Incorrect success percentage in rally detailed output

[Santosh Ananda]

Incorrect success percentage is seen in the rally detailed output when one of the atomic actions fails.

When an earlier atomic operation throws exceptions or fails(yars_action_2), the latter atomic operation(yars_actions_3) shows reduced success rate. However the former case(yars_action_2), which actually failed, doesn't show the same.

Here is an output of a sample scenario:
The scenario intentionally throws exception while executing the yars_action_2. The scenario file is attached.

Input:
{
    "YARS.atomic_action_test": [
    {
        "args": {
            "nothing_to_set" : false,
        },
        "runner": {
            "type": "constant",
            "times" : 5
        },
        "context": {
        }
    }
    ]
}

Output:
+------------------------------------------------------------------------------------+
| Response Times (sec) |
+---------------+-------+--------+--------+--------+-------+-------+---------+-------+
| action | min | median | 90%ile | 95%ile | max | avg | success | count |
+---------------+-------+--------+--------+--------+-------+-------+---------+-------+
| yars_action_1 | 2.001 | 4.004 | 4.004 | 4.004 | 4.004 | 3.203 | 100.0% | 5 |
| yars_action_2 | 1.0 | 1.001 | 2.603 | 2.803 | 3.003 | 1.601 | 100.0% | 5 |
| yars_action_3 | 1.001 | 1.501 | 2.001 | 2.002 | 2.002 | 1.501 | 80.0% | 5 |
| total | 4.002 | 6.006 | 8.408 | 8.708 | 9.008 | 6.256 | 80.0% | 5 |
+---------------+-------+--------+--------+--------+-------+-------+---------+-------+
Load duration: 30.0643792152
Full duration: 31.7704539299

After further debugging, found that this behaviour is seen after the below change was done.
https://github.com/openstack/rally/commit/32c481ee5f48d322c574b99dbc6a851086b89d83

The above change should also take care of the success rate in the rally detailed report.

[Alexander Maretskiy (maretskiy)]

This seems to be already fixed since is not reproduced on current master branch.
See details at http://paste.openstack.org/show/493344/

Now the results are:
+------------------------------------------------------------------------------------------------------------------+
| Response Times (sec) |
+---------------+-----------+--------------+--------------+--------------+-----------+-----------+---------+-------+
| Action | Min (sec) | Median (sec) | 90%ile (sec) | 95%ile (sec) | Max (sec) | Avg (sec) | Success | Count |
+---------------+-----------+--------------+--------------+--------------+-----------+-----------+---------+-------+
| yars_action_1 | 1.001 | 2.501 | 3.703 | 3.853 | 4.004 | 2.501 | 80.0% | 5 |
| yars_action_2 | 2.001 | 3.001 | 3.003 | 3.003 | 3.004 | 2.752 | 80.0% | 5 |
| yars_action_3 | 1.001 | 1.501 | 2.002 | 2.002 | 2.002 | 1.501 | 100.0% | 4 |
| total | 5.003 | 6.504 | 8.406 | 8.707 | 9.007 | 6.755 | 80.0% | 5

You see that all atomic actions (but yars_action_3) has 5 runs (this is correct), and 80% (because 1 iteration has failed),
and yars_action_3 has not started once so there are 4 runs and 100% success (all 4 iterations had no errors)