[image] cirros_img_url in rally.conf doesn't take effective

Bug #1530075 reported by Jianghua Wang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Rally
Fix Released
Medium
Jianghua Wang

Bug Description

I configured cirros_img_url in rally.conf, but it doesn't take effect but always use the default one.

root@node-2:~# grep -n cirros_img_url /etc/rally/rally.conf
656:#cirros_img_url = http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img
657:cirros_img_url = http://ca.downloads.xensource.com/OpenStack/cirros-0.3.4-x86_64-disk.vhd.tgz

I think it's a bug within https://github.com/openstack/rally/blob/master/rally/verification/tempest/config.py#L71
IMAGE_NAME = parse.urlparse(CONF.image.cirros_img_url).path.split("/")[-1]

the above line is located globally, so the urlparse goes before the conf file loaded?

Tags: verify
Changed in rally:
assignee: nobody → Jianghua Wang (wjh-fresh)
Changed in rally:
status: New → In Progress
Changed in rally:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/262636
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=fb49811bbfcb27e0e4f66d435ab2fdd63f4b0a14
Submitter: Jenkins
Branch: master

commit fb49811bbfcb27e0e4f66d435ab2fdd63f4b0a14
Author: jianghuaw <email address hidden>
Date: Thu Dec 31 00:39:29 2015 +0000

    Rally: get the correct IMAGE_NAME from cirros_img_url

    Current the statement which retrieves IMAGE_NAME from
    cirros_img_url is located in global place. So it's
    done before loading the configuration file.

    Closes-Bug: #1530075

    Change-Id: Ida75010fd3bf2cb6286390736ecd56567340de74

Changed in rally:
status: In Progress → Fix Released
tags: added: verify
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.