Dockerfile is in .dockerignore OMG

Bug #1515065 reported by Boris Pavlovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Rally
Fix Released
High
Boris Pavlovic

Bug Description

Dockerfile must not be in .dockerignore otherwise docker build doesn't work

Version
-------
Client version: 1.2.0
Client API version: 1.14
Go version (client): go1.2.1
Git commit (client): fa7b24f
OS/Arch (client): linux/amd64
Server version: 1.2.0
Server API version: 1.14
Go version (server): go1.2.1
Git commit (server): fa7b24f

Error message
-------------
FATA[0000] Dockerfile was excluded by .dockerignore pattern 'Dockerfile'

Tags: docker
Changed in rally:
assignee: nobody → Boris Pavlovic (boris-42)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to rally (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243878

Changed in rally:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/243878
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=166261c4d2cede78d893881f87eb80311eecb487
Submitter: Jenkins
Branch: master

commit 166261c4d2cede78d893881f87eb80311eecb487
Author: Boris Pavlovic <email address hidden>
Date: Tue Nov 10 16:33:29 2015 -0800

    Fix docker build command

    Dockerfile must not be in .dockerignore otherwise
    you can't run dockerbuild command

    Change-Id: I504f3dae20d675fed4bd98bffb33d0b14e9f11f5
    Closes-bug: #1515065

Changed in rally:
status: In Progress → Fix Committed
Revision history for this message
Sergey Skripnick (eyerediskin) wrote :

.dockerignore contain files which should not be copied by COPY command, so this files should not be in produced image. Dockerfile should not be in produced image, so it should be in .dockerignore.

How do you figured out that image wont build if Dockerfile is in .dockerignore?

It builds fine at least on version 1.0.1, build 990021a

Changed in rally:
status: Fix Committed → Invalid
importance: High → Low
description: updated
Changed in rally:
status: Invalid → Triaged
importance: Low → High
Changed in rally:
status: Triaged → Fix Committed
Revision history for this message
Sergey Skripnick (eyerediskin) wrote :

Yeah, there is a bug in docker-1.2.0

https://github.com/docker/compose/issues/1329

So we should keep .dockerignore without Dockerfile if we want to support buggy docker version

Changed in rally:
milestone: none → 0.1.2
Changed in rally:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.