iteration numbers in report are inconsisten

Bug #1507307 reported by Yair Fried
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Rally
Fix Released
Low
Anshul

Bug Description

In failure lists the iteration numbers are zero-base, while the graphs start in #1

Changed in rally:
importance: Undecided → Low
status: New → Triaged
Changed in rally:
status: Triaged → Confirmed
Changed in rally:
status: Confirmed → Triaged
Anshul (anshulbehl-19)
Changed in rally:
assignee: nobody → Anshul (anshulbehl-19)
Revision history for this message
Anshul (anshulbehl-19) wrote :

I have attached a sample failure html template, I want to confirm before working on this bug,
If I click on failure tab on this template I can see a 0-9 list while I check the first graph on first tab on the x-axis it is a 1-10 list.
Please confirm if this is the bug I will start working on the same.

Thanks

Revision history for this message
Yair Fried (yfried) wrote :

Hi,
I believe you understand the issue.
Please see my initial work on this https://review.openstack.org/#/c/236844/ .

Ideally, the infra should have picked up my patch and assigned me to this bug as well as post a link to the patch here.

I'm happy to step away if you think you are up to it. In case you change your mind, please assign the bug to me.

Good luck

Revision history for this message
Anshul (anshulbehl-19) wrote : Re: [Bug 1507307] Re: iteration numbers in report are inconsisten

Hi Yair,

I figured out that if I make a simple change to
rally/ui/templates/task/report.mako with,

ng-repeat-start="i in scenario.errors track by $index"
                  ng-click="i.expanded = ! i.expanded">
                <td>
                  <span ng-hide="i.expanded">&#9658;</span>
                  <span ng-show="i.expanded">&#9660;</span>
                <td>{{i.iteration+1}} <-- This being the change

the issue gets fixed in html reports.
If you have time can you check if this will work if not where else
this can cause a regression, meanwhile I am figuring out a way to
sign contributor license of openstack ( not sure why its not working).

Thanks for being patient with me :)

Regards,
Anshul Behl

On Tue, Oct 20, 2015 at 11:25 PM, Yair Fried <email address hidden> wrote:
> Hi,
> I believe you understand the issue.
> Please see my initial work on this https://review.openstack.org/#/c/236844/ .
>
> Ideally, the infra should have picked up my patch and assigned me to
> this bug as well as post a link to the patch here.
>
> I'm happy to step away if you think you are up to it. In case you change
> your mind, please assign the bug to me.
>
> Good luck
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1507307
>
> Title:
> iteration numbers in report are inconsisten
>
> Status in Rally:
> Triaged
>
> Bug description:
> In failure lists the iteration numbers are zero-base, while the graphs
> start in #1
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/rally/+bug/1507307/+subscriptions

Changed in rally:
status: Triaged → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on rally (master)

Change abandoned by Boris Pavlovic (<email address hidden>) on branch: master
Review: https://review.openstack.org/236844
Reason: fixed in master

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.