Invalid bug, don't try to fix

[Brian Curtin]

They magically allow things to pass. This is bad.

Any usage should be replaced with the Mock class and explicit attributes should be set on it.

[Brian Curtin (brian.curtin)]

These exist in 84 places as of today.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/250226
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=481aedc665a423081d74313bdcd074b9a6c788fc
Submitter: Jenkins
Branch: master

commit 481aedc665a423081d74313bdcd074b9a6c788fc
Author: tengqm <email address hidden>
Date: Thu Nov 26 03:30:52 2015 -0500

    Replace 'MagicMock' with 'Mock'

    This is part of an effort to replace all 'MagicMock' usage with 'Mock'.

    Change-Id: Ia0a62dd704640a1e8885856b3dd0402bafd94c86
    Partial-Bug: #1475722

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/251175

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/251175
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=17c5559fd6d35c5f0ed47af568ee9e66e823710e
Submitter: Jenkins
Branch: master

commit 17c5559fd6d35c5f0ed47af568ee9e66e823710e
Author: tengqm <email address hidden>
Date: Sun Nov 29 20:59:30 2015 -0500

    Replace 'MagicMock' with 'Mock'

    This is the closing part of an effort to replace all 'MagicMock' with
    'Mock'.

    Change-Id: Ib581fdb2ce62f8275834287caa76a083e64b81a5
    Closes-Bug: #1475722

[Steve Martinelli (stevemar)]

Automatically unassigning due to inactivity.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/369826

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/369826
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=bc222e97b155152be3c8cced987ef1d443076d10
Submitter: Jenkins
Branch: master

commit bc222e97b155152be3c8cced987ef1d443076d10
Author: qtang <email address hidden>
Date: Wed Sep 14 13:27:31 2016 +0800

    Replace 'MagicMock' with 'Mock'

    Change-Id: I7aeceede6bd3cb88cf04f398454f9758dbee20f1
    Closes-Bug: #1475722

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373620

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373640

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373684

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373693

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373712

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373721

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373725

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373735

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373737

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373792

[Sharat Sharma (sharat-sharma)]

https://review.openstack.org/#/c/373792/ heatclient

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373800

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373803

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373821

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373826

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373832

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373877

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373917

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373925

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373927

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373940

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373946

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373948

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373975

[OpenStack Infra (hudson-openstack)]

Change abandoned by sonu (<email address hidden>) on branch: master
Review: https://review.openstack.org/373925

[sonu (sonu-bhumca11)]

Hi

what exactly is the issue here?

also is there any checks available for this to avoid regression?

It is failing while we use Mock

for e.g

x = mock.MagicMock(tst='abc')
>>> x[0]

>>> x = mock.Mock(tst='abc')

>>> x[0]
Traceback (most recent call last):
  File "", line 1, in
TypeError: 'Mock' object does not support indexing

[gordon chung (chungg)]

removing all telemetry related projects. can we please stop creating these copy/paste bugs and adding all projects. i don't want to get emails on every single update unrelated to projects i care about.

please reopen bugs individually with less generic explanation/description.

[gordon chung (chungg)]

awesome. can't remove projects because there are so many projects it times out. sigh.

[Brian Curtin (brian.curtin)]

I have no idea what you people are doing. This was for openstacksdk and was solved a while ago.

Gordon, I'll see if I can remove things that look like telemetry.

[Brian Curtin (brian.curtin)]

Apparently I can't do anything about it either, so unsubscribing from the bug email.

[gordon chung (chungg)]

good idea. thanks for trying Brian.

[Sean Dague (sdague)]

To all contributors to this bug. While this looks like helping, it is not. This kind of bug is largely a waste of time.

Before adding more than 4 projects to a bug, please email the openstack-dev mailing list and ensure this is actually a cross cutting issue that people actually believe should be fixed. This just causes busy work for projects, is not helpful.

[Sean Dague (sdague)]

I have deleted every project I had authority to for this bug. Please do not add any projects to this specific bug unless you've gotten acknowledgement that the project team believes this is a bug in their project.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Wenyan Zhang (<email address hidden>) on branch: master
Review: https://review.openstack.org/373927

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/374630

[David Stanek (dstanek)]

I agree with Sean's comments. Is there a known case where MagicMock causes broken tests?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/375208

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/375208
Committed: https://git.openstack.org/cgit/openstack/heat-cfntools/commit/?id=590b3fb99635157a3963f67995593b872f92a1c1
Submitter: Jenkins
Branch: master

commit 590b3fb99635157a3963f67995593b872f92a1c1
Author: shizhihui <email address hidden>
Date: Fri Sep 23 10:57:16 2016 +0800

    Replace 'MagicMock' with 'Mock'

    Change-Id: I24e87a1c341f63929f93d7306782e3e9d6b398fb
    Partial-Bug: #1475722

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-openstackclient 3.3.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sharat Sharma (<email address hidden>) on branch: master
Review: https://review.openstack.org/373725

[John L. Villalovos (happycamp)]

Please stop adding projects to this bug. It is not a valid bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/414475

[OpenStack Infra (hudson-openstack)]

Change abandoned by Madhuri Kumari (<email address hidden>) on branch: master
Review: https://review.openstack.org/414475
Reason: The bug has been marked as invalid, so abandoning it.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-neutronclient 6.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano-dashboard 3.1.0 release.