Nova boot from volume functionallity stop working

[Boris Pavlovic]

Rally benchmarks related to booting from volume functionality stopped working.

Like:
NovaServers.boot_server_from_volume

We are getting such errors:

Resource <Server: rally_novaserver_fygmxtgijxuuxtmc> has ERROR status: No valid host was found. There are not enough hosts available.

All patches in Rally are facing it. For example this one: https://review.openstack.org/#/c/147394/

[Boris Pavlovic (boris-42)]

Patch that reverts change that introduce this bug:

https://review.openstack.org/#/c/147751/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/147769

[John Garbutt (johngarbutt)]

This seems to turn up in the logs:

2015-01-15 22:27:03.301 25240 ERROR nova.compute.manager [-] [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] Instance failed to spawn
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] Traceback (most recent call last):
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] File "/opt/stack/new/nova/nova/compute/manager.py", line 2290, in _build_resources
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] yield resources
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] File "/opt/stack/new/nova/nova/compute/manager.py", line 2160, in _build_and_run_instance
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] flavor=flavor)
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 2396, in spawn
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] flavor=flavor)
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 4086, in _get_guest_xml
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] context, flavor=flavor)
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 3935, in _get_guest_config
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] flavor)
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 3271, in _get_guest_storage_config
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] vol.save(nova_context.get_admin_context())
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320] TypeError: save() takes exactly 1 argument (2 given)
2015-01-15 22:27:03.301 25240 TRACE nova.compute.manager [instance: b7c0d211-c6d8-45d1-b720-dcfe6806f320]

[John Garbutt (johngarbutt)]

Above taken from: http://logs.openstack.org/94/147394/5/check/gate-rally-dsvm-rally/ae2519a/logs/screen-n-cpu.txt.gz

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/147769
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=abd734ab65b4ef01a4139dbd8eae22167d61d428
Submitter: Jenkins
Branch: master

commit abd734ab65b4ef01a4139dbd8eae22167d61d428
Author: Boris Pavlovic <email address hidden>
Date: Fri Jan 16 10:21:43 2015 +0300

    Unblock Rally gates cause by nova bug 1411525

    Remove SLA checks from failing benchmarks

    Change-Id: I81ad3bb01db59fb3ecf5ee855c9ca22bb6d34bc3
    Related-Bug: #1411525

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/147751
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3111d4558cc5c0709591ebd9c6ed49a162b4f510
Submitter: Jenkins
Branch: master

commit 3111d4558cc5c0709591ebd9c6ed49a162b4f510
Author: Boris Pavlovic <email address hidden>
Date: Fri Jan 16 08:34:34 2015 +0300

    Revert "initialize objects with context in block device"

    This breaks nova boot VM from functionallity

    As well it breaks Rally gates so I think it is critical cause
    it is blocking work on Rally.

    As well this was not tested by tempest. Cause this is disabled
    in gates

    This reverts commit 570c98cb9e9e7327477d92c52bfdc0a28ab7f88e.

    Closes-bug: #1411525
    Change-Id: I5ecc165621c803726c1c8bbcd69a12d84e6a05a2