Use everywhere " instead of '

Bug #1405884 reported by Boris Pavlovic
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Rally
Fix Released
Low
plieb

Bug Description

Change all occurences of ' to ".

E.g.:

before:

  some_string = 'fafdafa'

after:

  some_string = "fafdafa"

---

before:

  some_dict['some_key']

after:

  some_dict["some_key"]

NOTE: DO NOT CHANGE ALL SUCH LINES IN ONE PATCH. SPLIT it maximum 200-300 lines per patch...

Tags: code-cleanup
Changed in rally:
status: New → Triaged
importance: Undecided → Low
plieb (jliberma)
Changed in rally:
assignee: nobody → plieb (jliberma)
Changed in rally:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/146923
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=20d6a0feb171982e28a0c255f36cb66e7ae863bf
Submitter: Jenkins
Branch: master

commit 20d6a0feb171982e28a0c255f36cb66e7ae863bf
Author: jacobliberman <email address hidden>
Date: Tue Jan 13 10:39:02 2015 -0600

    Replace ' with " in aas/rest

    Partial-Bug: 1405884

    Change-Id: I841f5c092909164cc8b11e6eb8d37b152d5f9e58

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to rally (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148000

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/148006

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/148000
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=a25069bc933e6185ddf7dba1a581153210dbed1d
Submitter: Jenkins
Branch: master

commit a25069bc933e6185ddf7dba1a581153210dbed1d
Author: jacobliberman <email address hidden>
Date: Fri Jan 16 15:28:03 2015 -0600

    Replace ' with " in rally/*.py

    Change-Id: I6555a3ed1364c21fa4931909760307bf2fb4b85e
    Partial-Bug: 1405884

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on rally (master)

Change abandoned by Jacob Liberman (<email address hidden>) on branch: master
Review: https://review.openstack.org/148006

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to rally (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148851

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/149574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/149584

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/149594

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on rally (master)

Change abandoned by Jacob Liberman (<email address hidden>) on branch: master
Review: https://review.openstack.org/149594
Reason: Do not touch rally/openstack directory

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/148851
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=96fd52182aed95e4557bb02214cbc815a33080f6
Submitter: Jenkins
Branch: master

commit 96fd52182aed95e4557bb02214cbc815a33080f6
Author: jacobliberman <email address hidden>
Date: Wed Jan 21 03:11:18 2015 -0600

    Replace ' with " in rally/benchmark

    Partial bug: 1405884

    Change-Id: I2de902aa67c75ad09cd733926c94e216129fab6b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/149584
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=541b7967fc949357c5485bb80f1ead317869631c
Submitter: Jenkins
Branch: master

commit 541b7967fc949357c5485bb80f1ead317869631c
Author: jacobliberman <email address hidden>
Date: Fri Jan 23 05:33:26 2015 -0600

    Replace ' with " in rally/common

    Partial bug: 1405884

    Change-Id: I9df462cbf770cfeeb19c27ca683826aba7b01c54

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/148907
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=2455db7f648c18989e120a23c1da1cb5f6bc2343
Submitter: Jenkins
Branch: master

commit 2455db7f648c18989e120a23c1da1cb5f6bc2343
Author: Sergey Skripnick <email address hidden>
Date: Wed Jan 21 14:14:51 2015 +0200

    Allow setting DB for unittests via env & add psql support

    RALLY_UNITTEST_DB_URL may be used to change test database.

    Sample usage:

    export RALLY_UNITTEST_DB_URL="mysql://user:secret@localhost/rally"
    tox -epy27

    Fix postgress related bugs in unit tests.

    * All enums should have name
    * Fix invalid unit tests

    Closes-bug: #1413155
    Partial-bug: #1405884

    Co-Authored-By: Sergey Skripnick <email address hidden>
    Co-Authored-By: Boris Pavlovic <email address hidden>

    Change-Id: Ic741cb79eadf952c3dea99182c1e7d52992c9904

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to rally (master)

Fix proposed to branch: master
Review: https://review.openstack.org/150486

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/150517

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/150486
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=d5fb29ed30071692c5069a88efbc564cd49ec7b5
Submitter: Jenkins
Branch: master

commit d5fb29ed30071692c5069a88efbc564cd49ec7b5
Author: jacobliberman <email address hidden>
Date: Tue Jan 27 10:47:06 2015 -0600

    Replace ' with " in rally/deploy

    Partial bug: 1405884

    Change-Id: I01b47e020ab3f21ab087fe623dad0385056ff32b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/149574
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=7683f6b225232e851569514069cd2f772fd03e85
Submitter: Jenkins
Branch: master

commit 7683f6b225232e851569514069cd2f772fd03e85
Author: jacobliberman <email address hidden>
Date: Fri Jan 23 05:19:21 2015 -0600

    Replacing ' with " in rally/cmd

    Partial bug: 1405884

    Change-Id: I0a7b8e3d7d8ba2100f49083cd2cfc77f7d08afe5

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to rally (master)

Fix proposed to branch: master
Review: https://review.openstack.org/151299

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/151319

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/151319
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=6d0679affeb1a79508275475535242f147e3b566
Submitter: Jenkins
Branch: master

commit 6d0679affeb1a79508275475535242f147e3b566
Author: jacobliberman <email address hidden>
Date: Thu Jan 29 11:13:55 2015 -0600

    Replace ' with " in tests/unit/benchmark

    Partial bug: 1405884

    Change-Id: Ia6f5167dc829db65f3fc61a504cf1d0c1e47c8fb

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/151299
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=b1cad65d16199d873a3db6ae0f77f3f07d7c5b50
Submitter: Jenkins
Branch: master

commit b1cad65d16199d873a3db6ae0f77f3f07d7c5b50
Author: jacobliberman <email address hidden>
Date: Thu Jan 29 10:28:46 2015 -0600

    Replace ' with " in [doc, samples]

    Partial bug: 1405884

    Change-Id: If6bebfbdd1243adb88fcc3cb015c8f15399e8934

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/150517
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=3ad53636da60fa96ad6a5d03114f0aa947a4c947
Submitter: Jenkins
Branch: master

commit 3ad53636da60fa96ad6a5d03114f0aa947a4c947
Author: jacobliberman <email address hidden>
Date: Tue Jan 27 11:47:36 2015 -0600

    Replace ' with " in rally/[objects,ui,verification]

    Change-Id: Ia086ac725fd8ec3de7e40f0d53a346db3a69d5d9
    Partial-Bug: 1405884

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to rally (master)

Fix proposed to branch: master
Review: https://review.openstack.org/152202

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/152613

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/152624

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/152613
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=3498071401725d915e74462193fd74e5f2bd3324
Submitter: Jenkins
Branch: master

commit 3498071401725d915e74462193fd74e5f2bd3324
Author: jacobliberman <email address hidden>
Date: Tue Feb 3 10:48:15 2015 -0600

    Replace ' with " in tests/unit/[common,deploy,doc,fixtures]

    Partial bug: 1405884

    Change-Id: I0100649c32bb911dab345c40492aa148ed1832c6

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/152624
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=246975a5c9d45459f987cd9ba60d2ad8e8582fc2
Submitter: Jenkins
Branch: master

commit 246975a5c9d45459f987cd9ba60d2ad8e8582fc2
Author: jacobliberman <email address hidden>
Date: Tue Feb 3 11:19:43 2015 -0600

    Replace ' with " in tests/unit/verification

    Partial bug: 1405884

    Change-Id: I6f4e08a04ce1e67fa4bedf299b9c7f8def36902b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/152202
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=f048c6a6332e0651457295ef2577b88583f27e3c
Submitter: Jenkins
Branch: master

commit f048c6a6332e0651457295ef2577b88583f27e3c
Author: jacobliberman <email address hidden>
Date: Mon Feb 2 11:25:49 2015 -0600

    Replace ' with " in tests/unit/[aas,cmd]

    Partial bug: 1405884

    Change-Id: I820e5c60b14f323a7d71f175eefe4560552c6f46

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to rally (master)

Fix proposed to branch: master
Review: https://review.openstack.org/153316

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/153316
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=d25fd5b447a74f93aa43c4215d6eac04f673274e
Submitter: Jenkins
Branch: master

commit d25fd5b447a74f93aa43c4215d6eac04f673274e
Author: jacobliberman <email address hidden>
Date: Thu Feb 5 11:54:56 2015 -0600

    Replace ' with " in rally/benchmark and tests/unit

    Partial bug: 1405884

    Change-Id: I43cb7440b7b2a284ff08538860b1f85c1da0925d

Changed in rally:
status: In Progress → Fix Committed
Changed in rally:
milestone: none → 0.0.2
Changed in rally:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.