Quote button has two states even though it's not stateful

[David Macek]

The Quote button has two states (pressed, not pressed) even though it doesn't work as a switch-button.

[Cirroz (pomozoff-gmail)]

Which DE do you use? Which linux distro? GTK2 or GTK3?
The plugin's working fine on GTK2.
Since I switched to OSX, I didn't tested the plugin with GTK3.
May be it needs some changes to support new GTK.

[David Macek (david-macek-0)]

DE?

My configuration:
Pidgin v2.10.0
Windows 7x64 Pro
GTK v2 (gtk2-runtime-2.16.6-2010-05-12-ash.exe from sf.net/projects/gtk-win/)

Also, now I found out that this only happens when the inserted text causes the button mouse cu

[David Macek (david-macek-0)]

DE?

My configuration:
Pidgin v2.10.0
Windows 7x64 Pro
GTK+ v2 (gtk2-runtime-2.16.6-2010-05-12-ash.exe from sf.net/projects/gtk-win/)

I completely forgot that I don't use the Pidgin's prepackaged GTK+. Ever since they stopped building a stand-alone installer, I moved to the gtk-win project. I may have a slightly weird installation of the libraries since I experimented with installing the v2.20 branch, which breaks drag-and-drop for Pidgin.

Also, now I found out that this only happens when the inserted text causes the button to jump away from under the mouse cursor (i.e. when the textbox expands and the mouse cursor wasn't pointing at the top of the button).

[Cirroz (pomozoff-gmail)]

> DE?

Desktop Environment - GNOME, XFCE, KDE

> Windows 7x64 Pro

Oh, I forgot the Windows, I see.

> Also, now I found out that this only happens when the inserted text causes the button to jump away from under the mouse cursor (i.e. when the textbox expands and the mouse cursor wasn't pointing at the top of the button).

I'm going to reproduce this behavior in this environment, but unfortunately, looks like I can't fix this bug, I think it's a GTK's "feature". I use GTK's API as is.

[David Macek (david-macek-0)]

I just noticed that the "Quote" button behaves differently from the other buttons on the toolbar. The other buttons wait with their actions once I stop holding the mouse button, but the Quote button reacts immediately after pressing the mouse button.

I guess this corresponds, in order, to Gtk's button-release-event and button-press-event signals. Could you try connecting the handler to the other signal to see if it helps? I'll gladly try any test builds on my system, if you need and don't have access to a Windows machine.

[Cirroz (pomozoff-gmail)]

Hello David,
I do not use Pidgin last time.
I will try to fix your issue in sources asap, but I can't build it.

Best Regards,
Anton.

[Cirroz (pomozoff-gmail)]

Check Gihub for sources, please: https://github.com/pomozoff/quotetext

[Cirroz (pomozoff-gmail)]

Changed Gtk's signal to button-release-event
Thx to David Macek

[David Macek (david-macek-0)]

Made an issue for it: https://github.com/pomozoff/quotetext/issues/1