We need a GridColumn superclass
Bug #812308 reported by
Jo-Erlend Schinstad
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Quickly Widgets |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
CheckColumn does many of the same things that a StringColumn does. And many things make sense to all columns. We should have a GridColumn superclass where these things are done, then make StringColumn, CheckColumn and FutureColumn inherit from that.
Related branches
lp:~joerlend.schinstad-deactivatedaccount/quidgets/main
- Rick Spencer: Approve
-
Diff: 35 lines (+6/-1)2 files modifiedquickly/widgets/dictionary_grid.py (+1/-1)
quickly/widgets/grid_column.py (+5/-0)
Revision history for this message
| Jo-Erlend Schinstad (joerlend.schinstad-deactivatedaccount) wrote | #1 |
| Changed in quidgets: | |
| milestone: | none → 12.03 |
| status: | New → Fix Committed |
| Changed in quidgets: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The GridColumn should have properties for editable, resizable, clickable, etc. I also think it should be DictionaryGrids job to set these properties, not the *Columns themselves. Both StringColumn and CheckColumn currently sets both resizable and clickable to True. It feels like the wrong place to do that.