number of complitions for quota could be set bigger than sample size

Bug #1472594 reported by Alex
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
queXS
Confirmed
Low
Unassigned

Bug Description

in quotarow.php it's possible to set any value for number of complitions , EVEN NEGATIVE

guess requires some DB table field setting ajustment and extra querry/comparison/evaluation for sample count

currently fixed with adding "artificial" limits to input field attributes:
<input name="completions" id="completions" min="0" max="1000"size="6" maxlength="6" style="width:6em;" required type="number">

Tags: quotas
Alex (ddrmoscow)
summary: - number of complitions for quota could exceed sample
+ number of complitions for quota could be set bigger than sample size
description: updated
Revision history for this message
Adam Zammit (adamzammit) wrote :

You are right Alex - quota completions are not currently validated.

I think for the mainline it would be best if no artificial limits were imposed as this could be misleading. As applying quotas is a bit of an "Advanced" feature and the inputted result is displayed in the quota reports, I think for now it will be fine to leave unvalidated until a meaningful validation function is implemented (such as maximum available records)

Changed in quexs:
status: New → Confirmed
importance: Undecided → Low
Alex (ddrmoscow)
tags: added: quotas
Revision history for this message
Alex (ddrmoscow) wrote :

That's it ! - validation ... Totally forgotten this word, lol :-)))

That's a good puzzle - validation function for quota values. Was thinking of it too, but it's not so obvious, requires some case/conditon modeling.
As to "complex_quota" update - current logic (as far as I understood) is: Set quota value - set questions restrictions - set sample restrictions - apply Quota (smth like limit N cases where {X} question restrictions have {Y}sample restrictions).

Would be nice to have some short wiki for current quota instrument especially for conditional logic that might be realized with it .

Thanks,
Alex

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.