Explain schema and table name pattern

Bug #704617 reported by cowwoc on 2011-01-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Querydsl
Fix Released
Undecided
Unassigned

Bug Description

http://source.mysema.com/static/querydsl/1.8.0/reference/html/ch02s04.html mentions "schema name pattern" and "table name pattern" but does not explain what they are and how they are meant to be used.

The Javadoc for MetaDataExporter needs to explain this as well.

Thanks for the bug report. I updated the documentation.

Changed in querydsl:
status: New → Fix Committed

Released in 2.0.2-beta2

Changed in querydsl:
status: Fix Committed → Fix Released
cowwoc (gili) wrote :

Excuse me, I believe this issue isn't completely resolved. http://source.mysema.com/static/querydsl/2.0.9/reference/html/ch02s04.html still does not explain "schema name pattern" and "table name pattern".

cowwoc (gili) wrote :

I also noticed there is no explanation for innerClassesForKeys and exportBeans. I tried the Javadoc viewer against the Maven plugin but it doesn't seem that there is any Javadoc for any of these properties.

Changed in querydsl:
status: Fix Released → New

> Excuse me, I believe this issue isn't completely resolved. http://source.mysema.com/static/querydsl/2.0.9/reference/html/ch02s04.html still does not explain "schema name pattern" and "table name pattern".

It has been fixed in the documentation of the newer release 2.1.0. I updated also the webpage

> I also noticed there is no explanation for innerClassesForKeys and exportBeans. I tried the Javadoc viewer against the Maven plugin but it doesn't seem that there is any Javadoc for any of these properties.

Ok. Will be fixed soon.

cowwoc (gili) wrote :

Thanks Timo, it looks a lot better. If I may make a small suggestion:

1. Consider changing "namePrefix = name prefix for Q-types (default: Q)" to "namePrefix = name prefix for query classes (default: Q)" since it's not obvious what "Q-types" means.
2. Consider changing "schemaPattern = to restrict code generation to certain schemas (default: null)" to "schemaPattern = regular expression used to restrict code generation to certain schemas (default: null)" since it's not obvious what format the string may take. The name "pattern" implies that regular expressions are allowed but it's not immediately obvious. The same is true for "tableNamePattern."
3. For "exportBeans" consider adding "see section 2.4.13 (below)"

Thank you for your patience :)

Thanks for the suggestions. These have been applied to SVN trunk.

Changed in querydsl:
status: New → Fix Committed

Released in 2.1.2

Changed in querydsl:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers