Quantum cli gives an unhelpful error message if the attachment is is invalid

[Brad Hall]

Currently we get a 500, which as mentioned in another bug is unhelpful:

Exception:<type 'exceptions.Exception'> - [{'status_code': 500, 'message': ''}]
Command failed with error code: 500
Error message:<missing>

We could change the exception on an invalid attachment to be a new exception (with a new http status code) that will allow us to use the arguments passed in to attach_resource in the client_lib.

[Hitesh Wadekar (hitesh-wadekar)]

Brad/Dan,

I would love to fix this issue. Would you please give me some an overview about it?

Will it be helpful if we add new status code?

Thanks,
Hitesh

[Hitesh Wadekar (hitesh-wadekar)]

Maru,

Could you please tell me what commands did you try for this?

Sorry I was busy with other stuff, thus I was not able to reach out for this bug early?

Thanks,
Hitesh

[Maru Newby (maru)]

Hitesh: Brad, the bug's reporter, would be the best person to talk to.

[Brad Hall (bgh)]

Hi Hitesh,

If you use the plug_attachment quantum cli command with an attachment that is invalid [defined by the plugin] then the error message is unhelpful (just a 500). It would be better to have a new exception: InvalidAttachmentException (or something like that) to indicate what the problem was.

[Hitesh Wadekar (hitesh-wadekar)]

Thanks Brad and Maru,

I will fix it as soon as possible and will send the file for review soon.

Thanks once again.

Regards,
Hitesh Wadekar

On Tue, Apr 24, 2012 at 1:46 AM, Brad Hall <email address hidden>wrote:

> Hi Hitesh,
>
> If you use the plug_attachment quantum cli command with an attachment
> that is invalid [defined by the plugin] then the error message is
> unhelpful (just a 500). It would be better to have a new exception:
> InvalidAttachmentException (or something like that) to indicate what the
> problem was.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/907123
>
> Title:
> Quantum cli gives an unhelpful error message if the attachment is is
> invalid
>
> Status in OpenStack Quantum (virtual network service):
> Confirmed
>
> Bug description:
> Currently we get a 500, which as mentioned in another bug is
> unhelpful:
>
> Exception:<type 'exceptions.Exception'> - [{'status_code': 500,
> 'message': ''}]
> Command failed with error code: 500
> Error message:<missing>
>
> We could change the exception on an invalid attachment to be a new
> exception (with a new http status code) that will allow us to use the
> arguments passed in to attach_resource in the client_lib.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/907123/+subscriptions
>

[VINAY PATKAR (vinay-patkar-deactivatedaccount)]

hi ,

i was trying to fix this bug, i need some information
>is this bug still valid??
>could you give more info on what do you mean by plug_attachment invalid???
>what command did you try exactly??

[Hitesh Wadekar (hitesh-wadekar)]

Hi Vinay,

When we attach invalid plugin it should give an error message like "Invalid
attachment", even I am fixing this bug, still working on ...We will have to
add more partmeters to API. or API should return something which we can
recognize as a invlid attachment.

Invalid attachment would be anything that wouldn't fit the requirements.

1. Not present in the database.
2. any random string or number or combinations.

Brad or Maru, Could you please confirm this?

Thanks,
Hitesh

On Mon, May 14, 2012 at 9:51 PM, VINAY PATKAR <email address hidden>wrote:

> hi ,
>
> i was trying to fix this bug, i need some information
> >is this bug still valid??
> >could you give more info on what do you mean by plug_attachment invalid???
> >what command did you try exactly??
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/907123
>
> Title:
> Quantum cli gives an unhelpful error message if the attachment is is
> invalid
>
> Status in OpenStack Quantum (virtual network service):
> Confirmed
>
> Bug description:
> Currently we get a 500, which as mentioned in another bug is
> unhelpful:
>
> Exception:<type 'exceptions.Exception'> - [{'status_code': 500,
> 'message': ''}]
> Command failed with error code: 500
> Error message:<missing>
>
> We could change the exception on an invalid attachment to be a new
> exception (with a new http status code) that will allow us to use the
> arguments passed in to attach_resource in the client_lib.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/907123/+subscriptions
>

[VINAY PATKAR (vinay-patkar-deactivatedaccount)]

Hi Hitesh,

 According to Hall "If you use the plug_attachment quantum cli command with an attachment that is invalid [defined by the plugin]", I was looking into quantum code, i couldn't find any plug_attachment. I was trying to reproduce the bug.

1. Which branch of quantum you are using?
2. Are you able to reproduce the bug??

[dan wendlandt (danwent)]

Hi Vinay,

I'm not sure what plugin was used to create the bug, but you should easily recreate the circumstances by tweaking the SamplePlugin to raise an exception any time plug_attachment is called.

I will note that in the v2.0 version of the API, the use of an explicit "plug_attachment" call will go away, so this bug may soon become less important.

[Hitesh Wadekar (hitesh-wadekar)]

Hi Vinay,

Use this command from cli 'plug_iface'. Attach the invalide attachment.

Please look at the code, python-quantumclient->quantum->client->cli_lib.py

I am also fixing this.

Thanks,
Hitesh

On Tue, May 15, 2012 at 8:39 PM, dan wendlandt <email address hidden>wrote:

> Hi Vinay,
>
> I'm not sure what plugin was used to create the bug, but you should
> easily recreate the circumstances by tweaking the SamplePlugin to raise
> an exception any time plug_attachment is called.
>
> I will note that in the v2.0 version of the API, the use of an explicit
> "plug_attachment" call will go away, so this bug may soon become less
> important.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/907123
>
> Title:
> Quantum cli gives an unhelpful error message if the attachment is is
> invalid
>
> Status in OpenStack Quantum (virtual network service):
> Confirmed
>
> Bug description:
> Currently we get a 500, which as mentioned in another bug is
> unhelpful:
>
> Exception:<type 'exceptions.Exception'> - [{'status_code': 500,
> 'message': ''}]
> Command failed with error code: 500
> Error message:<missing>
>
> We could change the exception on an invalid attachment to be a new
> exception (with a new http status code) that will allow us to use the
> arguments passed in to attach_resource in the client_lib.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/907123/+subscriptions
>

[Chinmay Kulkarni (chnm-kulkarni)]

hey , i've been trying to recreate this bug but haven't been able to do so...frm what i see the exception codes are more or less plugin dependant, so is there a possibility of giving me info about the specific plugin that gave up this bug??

[dan wendlandt (danwent)]

Hi Chinmay,

we're actually working on a new version of the API (v2) which does not include a "plug_iface" operation, so perhaps we should just close this bug, as I want to make sure your time is well spent.

[Chinmay Kulkarni (chnm-kulkarni)]

hey Dan,

That's great!! Thanks a lot for this update, will get to working on the other bugs then!