SubnetRoute changes don't propagete to dhcp agent

[Aaron Rosen]

The dhcp agent must be restarted to get SubnetRoute changes.

[Aaron Rosen (arosen)]

The notification of the dhcp agent is done in the api layer now so if a plugin adds a route without having an update subnet go through the api it needs to call _send_dhcp_notification

[Nachi Ueno (nati-ueno)]

Hi Aaron

Even if so, this bug may be valid for each plugin which is not call _send_dhcp_notification.
How do you think?

[Aaron Rosen (arosen)]

This is actually true. The dhcp agent just looks the the cidrs and not the host routes in refresh_dhcp_help. We need to modify NetworkCache to also account for host_routes

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24569

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25085

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24569
Committed: http://github.com/openstack/quantum/commit/885cc41ff033a24191e93d40cd39d858e108f1d8
Submitter: Jenkins
Branch: master

commit 885cc41ff033a24191e93d40cd39d858e108f1d8
Author: Aaron Rosen <email address hidden>
Date: Wed Mar 20 18:19:04 2013 -0700

    Fix race condition in dhcp agent

    This patch fixes a race condition that can happen in the dhcp agent when
    a subnet is created and then a host route is then immediately added to that
    subnet following a subnet.update.end notification. The race condition occurs
    in refresh_dhcp_helper() where self.enable_dhcp_helper() gets called twice
    since the first call had not completed self.cache.put(network). This same race
    condition can also occur in the other events so lockutils.synchronized() is
    added to synchronize those code segments as well.

    Fixes bug 1155748

    Change-Id: I2ff52adc3dfebddd6d9c15d5dc79aa65be107179

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/25085
Committed: http://github.com/openstack/quantum/commit/4c53186e5a5349caa0fd3c5f21c1dd8c98debec2
Submitter: Jenkins
Branch: milestone-proposed

commit 4c53186e5a5349caa0fd3c5f21c1dd8c98debec2
Author: Aaron Rosen <email address hidden>
Date: Wed Mar 20 18:19:04 2013 -0700

    Fix race condition in dhcp agent

    This patch fixes a race condition that can happen in the dhcp agent when
    a subnet is created and then a host route is then immediately added to that
    subnet following a subnet.update.end notification. The race condition occurs
    in refresh_dhcp_helper() where self.enable_dhcp_helper() gets called twice
    since the first call had not completed self.cache.put(network). This same race
    condition can also occur in the other events so lockutils.synchronized() is
    added to synchronize those code segments as well.

    Fixes bug 1155748

    Change-Id: I2ff52adc3dfebddd6d9c15d5dc79aa65be107179