neutron

hasattr check for get_*_counts is invalid

Bug #1081259 reported by dan wendlandt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Critical
dan wendlandt
neutron 2013.1 "grizzly"
Folsom
Fix Released
Critical
dan wendlandt
neutron 2012.2.1

Bug Description

in the stable review (https://review.openstack.org/#/c/16386/) for the quota resource counting bug, it was pointed out that using has_attr to check if the plugin has a get_x_count method is invalid, since the code was updated to include those methods as part of the base plugin class, not just the DB plugin class as was originally the case.

dan wendlandt (danwent)
Changed in quantum:
assignee: nobody → dan wendlandt (danwent)
importance: Undecided → Critical
status: New → In Progress
milestone: none → grizzly-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/16566

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/16566
Committed: http://github.com/openstack/quantum/commit/43e76efcc5f86de7ec43c4524ff45f6986ed0680
Submitter: Jenkins
Branch: master

commit 43e76efcc5f86de7ec43c4524ff45f6986ed0680
Author: Dan Wendlandt <email address hidden>
Date: Tue Nov 20 12:59:20 2012 -0800

    fix broken logic of only using hasattr to check for get_x_counts

    bug 1081259

    Change-Id: I1dad596830685968ae47394e0e85afe1b72ab544

Changed in quantum:
status: In Progress → Fix Committed
Revision history for this message
dan wendlandt (danwent) wrote :

This should be squashed with this (https://review.openstack.org/#/c/16386/) and merged into stable/folsom

tags: added: folsom-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/16609

Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/16952

Mark McLoughlin (markmc)
tags: removed: folsom-backport-potential
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.