bin/quantum-nec-agent is missing

[Robert Kukura]

The executable for the NEC agent, bin/quantum-nec-agent, does not exist. It should be similar to those for the other agents.

[Mark McClain (markmcclain)]

quantum-nec-agent is listed as an console script entrypoint in setup.py. Is that not sufficient for packaging?

[Akihiro Motoki (amotoki)]

In some cases bin/*-agent is used directly and in other cases binary created by setup.py is used.
nova adopts a little different approach using "scirpts" instead of "console_scripts entrypoint" in setup.py.

 * In Fedora or Ubuntu packaging, they seem to just copy bin/*-agent to bin directory.
 * setup.py creates an script during installation, so there is no problem for people using pip.
 * In devstack, AGENT_BINARY (plugin agent) directly points to $QUANTUM_DIR/quantum/plugins/xxxx/agent/xxxx_agent.py at this moment. (Note that there is a pending patch https://review.openstack.org/#/c/11650/. It proposes calling agent binaries instead of agent files directly.)

All other agent have an agent binary under bin diretory. nec agent does not follow the current convention in quantum.
I think bin/quantum-nec-agent needs to be added.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/12923

[Mark McClain (markmcclain)]

For Folsom, I understand that we need to add this for consistency reasons. Long term, I don't know why we have two things that serve the same purpose. We should just choose a method early in Grizzly and give the packagers plenty of time to adapt.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/12923
Committed: http://github.com/openstack/quantum/commit/7e2db08e6f4ed5f0d640b4c07189a8edd0b28b28
Submitter: Jenkins
Branch: master

commit 7e2db08e6f4ed5f0d640b4c07189a8edd0b28b28
Author: Akihiro MOTOKI <email address hidden>
Date: Thu Sep 13 13:36:09 2012 +0900

    Add quantum-nec-agent to bin directory.

    Fixes bug 1050047

    Change-Id: I8b946b08b0dc58881a9f149d17623462e058debc

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/13266

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/13266
Committed: http://github.com/openstack/quantum/commit/5024b9dfdb5c27c27b3e4230e535fb2515d8d987
Submitter: Jenkins
Branch: milestone-proposed

commit 5024b9dfdb5c27c27b3e4230e535fb2515d8d987
Author: Akihiro MOTOKI <email address hidden>
Date: Thu Sep 13 13:36:09 2012 +0900

    Add quantum-nec-agent to bin directory.

    Fixes bug 1050047

    Change-Id: I8b946b08b0dc58881a9f149d17623462e058debc