Mir Motion event tool type on touch device is 0 (AMOTION_EVENT_TOOL_TYPE_UNKNOWN)
Bug #1371282 reported by
Brandon Schaefer
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
qtmir (Ubuntu) |
Fix Released
|
Undecided
|
Robert Carr |
Bug Description
When testing on a touch device to figure out if our event is a finger event vs a mouse event. Tool type == AMOTION_
There should be tests in place that generate a tool type (finger/mouse) event and asserts our tool type is getting set correctly.
Related branches
lp:~mir-team/qtmir/fix-touch-tooltypes
- PS Jenkins bot (community): Approve (continuous-integration)
- Daniel d'Andrada (community): Approve
- Gerry Boland (community): Needs Fixing
-
Diff: 19 lines (+8/-1)1 file modifiedsrc/modules/Unity/Application/mirsurfaceitem.cpp (+8/-1)
Changed in mir: | |
status: | New → Invalid |
Changed in qtmir: | |
status: | New → In Progress |
assignee: | nobody → Robert Carr (robertcarr) |
Changed in qtmir: | |
status: | In Progress → Fix Released |
no longer affects: | mir |
Changed in qtmir (Ubuntu): | |
assignee: | nobody → Robert Carr (robertcarr) |
no longer affects: | qtmir |
To post a comment you must log in.
Thanks for the bug report.
It's worth noting that touch apps/toolkits need to work even if the too type is not finger. Examples:
* Using a stylus on a touch screen
* Using a mouse with a touch screen
So make sure you're not only accepting tool type "finger".