Activity log for bug #1346481

Date Who What changed Old value New value Message
2014-07-21 19:28:04 Roberto Alsina bug added bug
2014-07-21 19:30:36 Roberto Alsina bug task added click-reviewers-tools
2014-07-21 19:36:57 Roberto Alsina attachment added com.ubuntu.developer.ralsina.hello_0.2_all.click https://bugs.launchpad.net/click-reviewers-tools/+bug/1346481/+attachment/4159396/+files/com.ubuntu.developer.ralsina.hello_0.2_all.click
2014-07-21 19:47:31 Roberto Alsina description When creating a click package with push notifications support, it needs to add a helper with its own hook and both the SDK and the click review tool get confused. The manifest is something like this: { "name": "com.ubuntu.developer.ralsina.hello", "description": "description of hello", "framework": "ubuntu-sdk-14.10-qml-dev2", "architecture": "all", "title": "hello", "hooks": { "hello": { "apparmor": "hello.json", "desktop": "hello.desktop" }, "helloHelper": { "apparmor": "helloHelper-apparmor.json", "push-helper": "helloHelper.json" } }, "version": "0.2", "maintainer": "Roberto Alsina <roberto.alsina@canonical.com>" } The click review tool will complain about missing desktop hooks for the push helper: [15:59:18] <beuno> = hooks = [15:59:18] <beuno> ERROR: could not find desktop hook for 'helloHelper' [15:59:37] <beuno> "error": { [15:59:38] <beuno> "lint_control_architecture_valid_contents": { [15:59:38] <beuno> "text": "found binaries for architecture 'all': lib/i386-linux-gnu/hello/libhellobackend.so" [15:59:40] <beuno> }, [15:59:43] <beuno> "lint_hooks": { [15:59:45] <beuno> "text": "more than one app key specified in hooks" [15:59:48] <beuno> } [15:59:50] <beuno> }, [15:59:51] <beuno> ERROR: Could not load 'helloHelper-apparmor.json'. Is it properly formatted? And the SDK will complain about "The manifest file needs to specify if this is a app or a scope" When creating a click package with push notifications support, it needs to add a helper with its own hook and both the SDK and the click review tool get confused. The manifest is something like this: {     "name": "com.ubuntu.developer.ralsina.hello",     "description": "description of hello",     "framework": "ubuntu-sdk-14.10-qml-dev2",     "architecture": "all",     "title": "hello",     "hooks": {         "hello": {             "apparmor": "hello.json",             "desktop": "hello.desktop"         },         "helloHelper": {             "apparmor": "helloHelper-apparmor.json",             "push-helper": "helloHelper.json"         }     },     "version": "0.2",     "maintainer": "Roberto Alsina <roberto.alsina@canonical.com>" } The click review tool will complain about missing desktop hooks for the push helper: [15:59:18] <beuno> = hooks = [15:59:18] <beuno> ERROR: could not find desktop hook for 'helloHelper' [15:59:37] <beuno> "error": { [15:59:38] <beuno> "lint_control_architecture_valid_contents": { [15:59:38] <beuno> "text": "found binaries for architecture 'all': lib/i386-linux-gnu/hello/libhellobackend.so" [15:59:40] <beuno> }, [15:59:43] <beuno> "lint_hooks": { [15:59:45] <beuno> "text": "more than one app key specified in hooks" [15:59:48] <beuno> } [15:59:50] <beuno> }, [15:59:51] <beuno> ERROR: Could not load 'helloHelper-apparmor.json'. Is it properly formatted? And the SDK will complain about "The manifest file needs to specify if this is a app or a scope" These are the new files mentioned in the manifest: ralsina@yoga:~/canonical/push-docs/hello$ cat helloHelper.json { "exec": "helloHelper" } ralsina@yoga:~/canonical/push-docs/hello$ cat helloHelper-apparmor.json { "policy_groups": [ "push-notification-client" ], "policy_version": 1.2 }
2014-07-21 21:39:56 Jamie Strandboge click-reviewers-tools: status New In Progress
2014-07-21 21:39:59 Jamie Strandboge click-reviewers-tools: assignee Jamie Strandboge (jdstrand)
2014-07-21 21:40:02 Jamie Strandboge click-reviewers-tools: importance Undecided High
2014-07-21 22:08:19 Jamie Strandboge branch linked lp:~jdstrand/click-reviewers-tools/lp1346481
2014-07-25 13:38:28 Jamie Strandboge click-reviewers-tools: status In Progress Fix Committed
2014-07-25 14:48:15 Daniel Holbach click-reviewers-tools: status Fix Committed Fix Released
2014-07-25 14:53:12 Launchpad Janitor branch linked lp:ubuntu/utopic-proposed/click-reviewers-tools
2014-08-04 08:16:00 Zoltan Balogh qtcreator-plugin-ubuntu: status New Invalid