The licence text does not appear translated

[Nicolas Delvaux]

Around line 100 in QreatorWindow.py there is:

about.set_license(_('Distributed under the GPL v3 license.\n' +
         'http://www.opensource.org/licenses/gpl-3.0.html'))

But, in the .pot, there is:
msgid "Distributed under the GPL v3 license.\n"

So this string appears in English in Qreator even if it was translated.

AFAIK, Gettext-tools are not clever enough to extract concatenated strings from source code.
So you should either use one unique string or close the gettext parenthesis after the "\n'" (this means the link won't be translated, but this won't break translations that were already made).

[David Planella (dpm)]

Committed fix in the app-review-packaging branch, thanks!

[Nicolas Delvaux (malizor)]

There is a problem: you dropped the trailing '\n' so the string no longer match what's in the .pot.
As you committed this in a branch, the translation template won't be updated in Launchpad so translators can't re-translate this string.

I see two solutions:
- re-add the '\n' in the string
- commit this in trunk, wait for updated translations and merge back translations in the app-review-packaging branch

[David Planella (dpm)]

Al 24/05/12 19:44, En/na Nicolas Delvaux ha escrit:
> There is a problem: you dropped the trailing '\n' so the string no longer match what's in the .pot.
> As you committed this in a branch, the translation template won't be updated in Launchpad so translators can't re-translate this string.
>
> I see two solutions:
> - re-add the '\n' in the string
> - commit this in trunk, wait for updated translations and merge back translations in the app-review-packaging branch
>

Thanks Nicolas, yes the idea is to merge the app-review-packaging branch
to trunk and then update the .pot file, but I'll do that once the app
has been approved in the App Review Board queue first [1]. Then I'll
update the .pot file and will do a new release.

[1] https://myapps.developer.ubuntu.com/dev/arb/

[David Planella (dpm)]

Fixed in the 12.05.6 release, .pot file updated. The string will not yet appear translated as at the time of release there weren't any translations. but translations should be shipped in tomorrow's daily build [1]. If that does not fix it, please feel free to reopen the bug.

[1]: https://launchpad.net/~dpm/+archive/qreator-daily