Save does not save (solved)

[Laureano]

Hello.
This is not actually a bug but a design decision that i find odd.
I notice that if on a document I do some editing like higlhight somethimg and then I go to the "save" button that is on the left of the "print" button, which is actually the "save copy" button, choose a name and save, if I open that new file the highlight is not saved.
The only way it is saved is by going to "save as" (on the File menu)
It seems the "save copy" does a copy of the document without any changes. That's ok, but:
Why is the "save copy" button on the toolbar instead of the "save" or "save as", so you get the changes saved, as on every other application. May be useful for someone may be, but you need to be aware of that. I think it is anti-intuitive

qpdfview 0.4.14

[Adam Reichold (adamreichold)]

Hello Laureano,

thank you for taking the time to report this. I do agree with you assessment that "save" or "saveAs" should be the default tool bar action. (We already moved the keyboard shorts in that direction some time ago.) However you will have to take this up with the maintainer of the package you are using as the default file toolbar we ship here does contain neither the "Save copy" nor any other action but "openInNewTab" and "refresh", i.e.
```
static QStringList fileToolBar() { return QStringList() << "openInNewTab" << "refresh"; }
```

So I suspect that these defaults were patched in the package your are using. (I think this applies to the official Debian package and hence downstream Ubuntu as well.)

But do not, that you can change this via the settings dialog by modifying the "File tool bar" setting and replacing "saveCopy" by "save" or "saveAs" and then restarting the application.

Best regards,
Adam

[Laureano (laureanogasparin)]

Thank you for the clarification.

            "I do agree with you assessment that "save" or "saveAs" should
be the default tool bar action".

Great. But in my version "save" does not seem to be an available command.
Only "saveCopy" and "saveAs" appear on the file menu. If I change
"saveCopy" with plain "save" no save button is shown on tool bar. saveAs
do works

           "However you will have to take this up with the maintainer of
the package you are using as the default file toolbar we ship here does
contain neither the "Save copy" nor any other action but "openInNewTab" and
"refresh", i.e.
```
static QStringList fileToolBar() { return QStringList() << "openInNewTab"
<< "refresh"; }
```
So I suspect that these defaults were patched in the package your are
using. (I think this applies to the official Debian package and hence
downstream Ubuntu as well.)"

Oh, I see. Yes. Forgot to mention that I am using MX 18 (based on Debian
9). May be i'll send a message on their forum because it is a pity that
such a great software may become a little "tricky" if you think you have
save your changes when you actually didn't just because they have added a
button on the toolbar.

In fact I doubt whether "saveCopy" (saving ignoring changes) has any value
at all (isn't it's mere existence tricky)

Again thank you for you reply.

El jue., 16 abr. 2020 a las 4:11, Adam Reichold (<email address hidden>)
escribió:

> Hello Laureano,
>
> thank you for taking the time to report this. I do agree with you
> assessment that "save" or "saveAs" should be the default tool bar action.
> (We already moved the keyboard shorts in that direction some time ago.)
> However you will have to take this up with the maintainer of the package
> you are using as the default file toolbar we ship here does contain neither
> the "Save copy" nor any other action but "openInNewTab" and "refresh", i.e.
> ```
> static QStringList fileToolBar() { return QStringList() << "openInNewTab"
> << "refresh"; }
> ```
>
> So I suspect that these defaults were patched in the package your are
> using. (I think this applies to the official Debian package and hence
> downstream Ubuntu as well.)
>
> But do not, that you can change this via the settings dialog by
> modifying the "File tool bar" setting and replacing "saveCopy" by "save"
> or "saveAs" and then restarting the application.
>
> Best regards,
> Adam
>
> ** Changed in: qpdfview
> Status: New => Invalid
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1873082
>
> Title:
> Save does not save
>
> Status in qpdfview:
> Invalid
>
> Bug description:
> Hello.
> This is not actually a bug but a design decision that i find odd.
> I notice that if on a document I do some editing like higlhight
> somethimg and then I go to the "save" button that is on the left of the
> "print" button, which is actually the "save copy" button, choose a name and
> save, if I open that new file the highlight is not saved.
> The only way it is saved is by going to "save as" (on the File menu)
> It seems the "save copy" does a copy of the document without any
> changes. T...

[Adam Reichold (adamreichold)]

> But in my version "save" does not seem to be an available command.
Only "saveCopy" and "saveAs" appear on the file menu. If I change
"saveCopy" with plain "save" no save button is shown on tool bar

Version 0.4.14 is not the current version and the "save" action was introduced in version 0.4.17.