Shortcuts involving Control modifier not working in 0.4.2.99

[William Mitchell Jr]

hot keys are not visible or functional in 0.4.2.99

WM

Qt 4.8.4 -debug
bzr branch lp:qpdfview
Debian/Sid
KDE 4.8.4
kernel 3.2.41-2 i686

[Adam Reichold (adamreichold)]

Hello William,

Since neither me or Benjamin could reproduce these problems, can you try to narrow down the reasons for this to happen? Since you are also compiling Qt yourself, could you try to investigate this more thoroughly on your system, e.g. step through the "registerAction" method of the "ShortcutHandler" class using a debugger? Also, a complete list of your configuration options for the Qt library might be useful to diagnose the problem. (We had a user, who was unable to get the program to show its main window because support for iconv was disabled in his Qt build. There are a lot of possibilities...)

Best regards, Adam.

[William Mitchell Jr (wdmjun)]

I'll give the debugger a try.
Attached is a typescript of my configure terminal session.
WM

On Mon, Apr 29, 2013 at 11:48 AM, Adam Reichold <email address hidden>wrote:

> Hello William,
>
> Since neither me or Benjamin could reproduce these problems, can you try
> to narrow down the reasons for this to happen? Since you are also
> compiling Qt yourself, could you try to investigate this more thoroughly
> on your system, e.g. step through the "registerAction" method of the
> "ShortcutHandler" class using a debugger? Also, a complete list of your
> configuration options for the Qt library might be useful to diagnose the
> problem. (We had a user, who was unable to get the program to show its
> main window because support for iconv was disabled in his Qt build.
> There are a lot of possibilities...)
>
> Best regards, Adam.
>
> ** Changed in: qpdfview
> Importance: Low => Medium
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1174119
>
> Title:
> 0.4.2.99 no hot keys
>
> Status in qpdfview:
> Incomplete
>
> Bug description:
> hot keys are not visible or functional in 0.4.2.99
>
> WM
>
> Qt 4.8.4 -debug
> bzr branch lp:qpdfview
> Debian/Sid
> KDE 4.8.4
> kernel 3.2.41-2 i686
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qpdfview/+bug/1174119/+subscriptions
>

[Adam Reichold (adamreichold)]

(Maybe a simpler way to investigate this issue: What does the shortcuts tab in the settings dialog display and what happens if you try to reset the settings to their defaults?)

[Adam Reichold (adamreichold)]

From a first glancing look at it, it seems unlikely that your Qt configuration is missing functionality... Hopefully the debugger will tell us something useful.

[Adam Reichold (adamreichold)]

Hello again,

There is one thing that I noticed: GTK theme support is disabled in your build which usually shouldn't be a problem, but the QKeySequence constants are context sensitive (e.g. detect a KDE or GNOME environment) and maybe this logic depends the GTK theme support being present? (But this is really just a wild guess.)

Best regards, Adam.

[William Mitchell Jr (wdmjun)]

This is run on a server with no GUI environment.
I'm ssh -X into the server.
WM

On Tue, Apr 30, 2013 at 5:23 PM, Adam Reichold <email address hidden>wrote:

> Hello again,
>
> There is one thing that I noticed: GTK theme support is disabled in your
> build which usually shouldn't be a problem, but the QKeySequence
> constants are context sensitive (e.g. detect a KDE or GNOME environment)
> and maybe this logic depends the GTK theme support being present? (But
> this is really just a wild guess.)
>
> Best regards, Adam.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1174119
>
> Title:
> 0.4.2.99 no hot keys
>
> Status in qpdfview:
> Incomplete
>
> Bug description:
> hot keys are not visible or functional in 0.4.2.99
>
> WM
>
> Qt 4.8.4 -debug
> bzr branch lp:qpdfview
> Debian/Sid
> KDE 4.8.4
> kernel 3.2.41-2 i686
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qpdfview/+bug/1174119/+subscriptions
>

[William Mitchell Jr (wdmjun)]

Adam,
I apologize.
Upon further review, the Alt shortcut keys and the single shortcut keys on
the drop down menus are working both remotely via ssh -X and locally.
What wasn't (and isn't working) are the Ctrl shortcut keys from the main
menu (Ctrl-Q, Ctrl-P, Ctrl-S, Ctrl-T, Ctrl-O)
but this looks like it's not a bug just a product of the rewrite.
That said, I need the Ctrl shortcut keys.
So this bug should probably be renamed to "no Ctrl shortcut keys".
WM

On Tue, Apr 30, 2013 at 8:22 PM, William Mitchell Jr <email address hidden>wrote:

> This is run on a server with no GUI environment.
> I'm ssh -X into the server.
> WM
>
>
>
> On Tue, Apr 30, 2013 at 5:23 PM, Adam Reichold <email address hidden>wrote:
>
>> Hello again,
>>
>> There is one thing that I noticed: GTK theme support is disabled in your
>> build which usually shouldn't be a problem, but the QKeySequence
>> constants are context sensitive (e.g. detect a KDE or GNOME environment)
>> and maybe this logic depends the GTK theme support being present? (But
>> this is really just a wild guess.)
>>
>> Best regards, Adam.
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1174119
>>
>> Title:
>> 0.4.2.99 no hot keys
>>
>> Status in qpdfview:
>> Incomplete
>>
>> Bug description:
>> hot keys are not visible or functional in 0.4.2.99
>>
>> WM
>>
>> Qt 4.8.4 -debug
>> bzr branch lp:qpdfview
>> Debian/Sid
>> KDE 4.8.4
>> kernel 3.2.41-2 i686
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/qpdfview/+bug/1174119/+subscriptions
>>
>
>

[William Mitchell Jr (wdmjun)]

if the lines
m_openAction->setShortcut(tr("Ctrl-O"));
m_printAction->setShortcut(tr("Ctrl-P");
m_exitAction->setShortcut(tr("Ctrl-Q"));
are added to creatActions() in mainwindow.cpp
the Ctrl shortcut keys appear and are functional.
WM

On Wed, May 1, 2013 at 6:56 PM, William Mitchell Jr <email address hidden>wrote:

> Adam,
> I apologize.
> Upon further review, the Alt shortcut keys and the single shortcut keys on
> the drop down menus are working both remotely via ssh -X and locally.
> What wasn't (and isn't working) are the Ctrl shortcut keys from the main
> menu (Ctrl-Q, Ctrl-P, Ctrl-S, Ctrl-T, Ctrl-O)
> but this looks like it's not a bug just a product of the rewrite.
> That said, I need the Ctrl shortcut keys.
> So this bug should probably be renamed to "no Ctrl shortcut keys".
> WM
>
>
>
> On Tue, Apr 30, 2013 at 8:22 PM, William Mitchell Jr <email address hidden>wrote:
>
>> This is run on a server with no GUI environment.
>> I'm ssh -X into the server.
>> WM
>>
>>
>>
>> On Tue, Apr 30, 2013 at 5:23 PM, Adam Reichold <email address hidden>wrote:
>>
>>> Hello again,
>>>
>>> There is one thing that I noticed: GTK theme support is disabled in your
>>> build which usually shouldn't be a problem, but the QKeySequence
>>> constants are context sensitive (e.g. detect a KDE or GNOME environment)
>>> and maybe this logic depends the GTK theme support being present? (But
>>> this is really just a wild guess.)
>>>
>>> Best regards, Adam.
>>>
>>> --
>>> You received this bug notification because you are subscribed to the bug
>>> report.
>>> https://bugs.launchpad.net/bugs/1174119
>>>
>>> Title:
>>> 0.4.2.99 no hot keys
>>>
>>> Status in qpdfview:
>>> Incomplete
>>>
>>> Bug description:
>>> hot keys are not visible or functional in 0.4.2.99
>>>
>>> WM
>>>
>>> Qt 4.8.4 -debug
>>> bzr branch lp:qpdfview
>>> Debian/Sid
>>> KDE 4.8.4
>>> kernel 3.2.41-2 i686
>>>
>>> To manage notifications about this bug go to:
>>> https://bugs.launchpad.net/qpdfview/+bug/1174119/+subscriptions
>>>
>>
>>
>

[Adam Reichold (adamreichold)]

Hello again,

While adding those lines might help, it does neither explain nor solve the problem as using the 'QKeySequence::StandardKey' constants is not equivalent to using e.g. 'tr("Ctrl+O")'. I read through the code of Qt's QKeySequence and there are two further possibilities (c.f. 'QKeySequence::keyBindings(StandardKey)'):
1. 'QApplicationPrivate::currentPlatform()' does not work correctly and the key bindings are filtered. But would probably affect all keyboard shortcuts.
2. 'maybeSwapShortcut(int)' is active and replaces the Control by the Meta modifier. Are any Mac OS X systems involved?

Can you, using the settings dialog, enable the shortcuts you mentioned?

Best regards, Adam.

P.S.: I am not so sure this is a product of the rewrite since we have been using 'QKeySequence::StandardKey' for a long time.

[Adam Reichold (adamreichold)]

Hello William,

Silvan Scherrer, maintaining the qpdfview build on eComStation, found a problem with the keyboard shortcuts as well: They do not work if they are not actually specified in the configuration file, c.f. [1]. Could this also explain the behavior you have observed? Do your the problems you mentioned persist past trunk revision 1155?

Best regards, Adam.

[1] https://bugs.launchpad.net/qpdfview/+bug/1180050

[William Mitchell Jr (wdmjun)]

Adam,
Yes. That explains the problems I was experiencing with both the no
shortcuts and the no scrolling.
I now have compiled 0.4.3beta1 revision 1157 and have no problems with
shortcuts or scrolling.
I deleted ~/.config/qpdfview before testing this version.
Bill

Debian/Sid
KDE 4.8.4
Linux 3.2.41 i686
Qt 4.8.4 (debug mode)

On Sat, May 18, 2013 at 10:03 AM, Adam Reichold <email address hidden>wrote:

> Hello William,
>
> Silvan Scherrer, maintaining the qpdfview build on eComStation, found a
> problem with the keyboard shortcuts as well: They do not work if they
> are not actually specified in the configuration file, c.f. [1]. Could
> this also explain the behavior you have observed? Do your the problems
> you mentioned persist past trunk revision 1155?
>
> Best regards, Adam.
>
> [1] https://bugs.launchpad.net/qpdfview/+bug/1180050
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1174119
>
> Title:
> Shortcuts involving Control modifier not working in 0.4.2.99
>
> Status in qpdfview:
> Incomplete
>
> Bug description:
> hot keys are not visible or functional in 0.4.2.99
>
> WM
>
> Qt 4.8.4 -debug
> bzr branch lp:qpdfview
> Debian/Sid
> KDE 4.8.4
> kernel 3.2.41-2 i686
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qpdfview/+bug/1174119/+subscriptions
>