hw/remote/mpqemu-link.c:221: bad error checking ?
Bug #1926995 reported by
dcb
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
QEMU |
Fix Released
|
High
|
Unassigned |
Bug Description
hw/remote/
Source code is
if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) {
return false;
}
Maybe better code:
if (msg->cmd >= MPQEMU_CMD_MAX || msg->cmd < 0) {
return false;
}
It might be useful to switch on gcc compiler flag -Wlogical-op
to see these warnings.
Changed in qemu: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thanks, I've reported it on the mailing list, and a patch has now been posted here: /lists. gnu.org/ archive/ html/qemu- devel/2021- 05/msg02106. html
https:/