QEMU

qemu/migration/postcopy-ram.c:387: bad return expression ?

Bug #1885720 reported by dcb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QEMU
Fix Released
Undecided
Dr. David Alan Gilbert

Bug Description

qemu/migration/postcopy-ram.c:387:9: style: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]

Source code is

       return -1;

but

bool postcopy_ram_supported_by_host(

Revision history for this message
Thomas Huth (th-huth) wrote :

That looks like a bug, indeed!

Changed in qemu:
status: New → Confirmed
Revision history for this message
Dr. David Alan Gilbert (dgilbert-h) wrote :

Yes, I think a goto out; there makes sense; nearly 5 years old that error :-)

Changed in qemu:
assignee: nobody → Dr. David Alan Gilbert (dgilbert-h)
Revision history for this message
Dr. David Alan Gilbert (dgilbert-h) wrote :

Posted:
migration: postcopy take proper error return

Changed in qemu:
status: Confirmed → In Progress
Revision history for this message
Thomas Huth (th-huth) wrote :

Fix has been merged:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=617a32f5295ee4e

Changed in qemu:
status: In Progress → Fix Committed
Thomas Huth (th-huth)
Changed in qemu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.