qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault

[dcb]

qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122:16: warning: Logical conjunction always evaluates to false: alen <= 0 && alen >= sizeof(args) - 1. [incorrectLogicOperator]

Source code is

   if (alen <= 0 && alen >= sizeof(args) - 1) {

Maybe better code:

   if (alen <= 0 || alen >= sizeof(args) - 1) {

[Peter Maydell (pmaydell)]

This isn't QEMU code -- it's just the source for third-party ROMs that we ship with QEMU because we also ship the ROM binaries. Please report it to the upstream project.

[Peter Maydell (pmaydell)]

(Anything in a git submodule will be third-party code that's not part of QEMU.)