Disk corrupted after snapshot deletion
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
QEMU |
Expired
|
Undecided
|
Unassigned |
Bug Description
I found the vm disk corruption after snapshot deletion sometimes(the probability is very low, I'm afraid i can't reproduce it). And I found there is a patch for it as follow, but I'm not sure whether the patch repaired the bug.
Drain disk before snapshot deletion can't guarantee anything, there is still pending IO in snapshot-deletion process. Anyone can help?
author Zhang Haoyu <email address hidden> 2014-10-21 16:38:01 +0800
committer Stefan Hajnoczi <email address hidden> 2014-11-03 09:48:42 +0000
commit 3432a1929ee18e0
tree 13a81c0a46707d9
parent 573742a5431a99c
snapshot: add bdrv_drain_all() to bdrv_snapshot_
If there are still pending i/o while deleting snapshot,
because deleting snapshot is done in non-coroutine context, and
the pending i/o read/write (bdrv_co_do_rw) is done in coroutine context,
so it's possible to cause concurrency problem between above two operations.
Add bdrv_drain_all() to bdrv_snapshot_
Signed-off-by: Zhang Haoyu <email address hidden>
Reviewed-by: Paolo Bonzini <email address hidden>
Message-id: <email address hidden>
Signed-off-by: Stefan Hajnoczi <email address hidden>
Diffstat (limited to 'block/snapshot.c')
-rw-r--r-- block/snapshot.c 4
1 files changed, 4 insertions, 0 deletions
diff --git a/block/snapshot.c b/block/snapshot.c
index 85c52ff..698e1a1 100644
--- a/block/snapshot.c
+++ b/block/snapshot.c
@@ -236,6 +236,10 @@ int bdrv_snapshot_
return -EINVAL;
}
+
+ /* drain all pending i/o before deleting snapshot */
+ bdrv_drain_all();
+
if (drv->bdrv_
return drv->bdrv_
}
My qemu version is 2.1.2