hw/timer/altera_timer.c:207: bad size in memset ?

[dcb]

hw/timer/altera_timer.c:207:5: warning: ‘memset’ used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]

Source code is

     memset(t->regs, 0, ARRAY_SIZE(t->regs));

Maybe better code

     memset(t->regs, 0, R_MAX * sizeof( uint32_t));

[Peter Maydell (pmaydell)]

On 28 January 2017 at 13:16, dcb <email address hidden> wrote:
> Public bug reported:
>
> hw/timer/altera_timer.c:207:5: warning: ‘memset’ used with length equal
> to number of elements without multiplication by element size [-Wmemset-
> elt-size]
>
> Source code is
>
> memset(t->regs, 0, ARRAY_SIZE(t->regs));
>
> Maybe better code
>
> memset(t->regs, 0, R_MAX * sizeof( uint32_t));

Better still -- just memset(t->regs, 0, sizeof(t->regs));

Chris, could you send a patch to fix this, please?

thanks
-- PMM

[Thomas Huth (th-huth)]

This problem should have been fixed with QEMU v2.10.0:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=cc16ee9d4ecec35ea04e