qemu/hw/intc/arm_gicv3_cpuif.c:2433: bad expression ?

[dcb]

qemu/hw/intc/arm_gicv3_cpuif.c:2433]: (style) Expression '(X & 0x2000000000000000) == 0x1' is always false.

Source code is

           ((lr & ICH_LR_EL2_HW) == 1 || (lr & ICH_LR_EL2_EOI) == 0)) {

Maybe better code

           ((lr & ICH_LR_EL2_HW) != 0 || (lr & ICH_LR_EL2_EOI) == 0)) {

[Peter Maydell (pmaydell)]

Thanks for this bug report -- I have sent a patch making the proposed change: http://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg05030.html

[Peter Maydell (pmaydell)]

Now fixed in git master, commit d87576e38df7.