hw/dma/pl080.c:354: possible typo ?

Bug #1631773 reported by dcb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QEMU
Fix Released
Undecided
Unassigned

Bug Description

hw/dma/pl080.c:354:1: warning: V578 An odd bitwise operation detected: s->conf & (0x2 | 0x2). Consider verifying it.

Source code is

       if (s->conf & (PL080_CONF_M1 | PL080_CONF_M1)) {

Maybe better code

       if (s->conf & (PL080_CONF_M1 | PL080_CONF_M2)) {

Revision history for this message
Thomas Huth (th-huth) wrote :

Thanks for reporting the issue, patch has now been included here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=04bb79d1f519ae190a

Changed in qemu:
status: New → Fix Committed
Revision history for this message
Thomas Huth (th-huth) wrote :

Released with version 2.8.

Changed in qemu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.