hw/mc146818: error reading RTC_HOURS_ALARM
Bug #1090558 reported by
Antoine Mathys
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| QEMU |
Expired
|
Undecided
|
Unassigned | ||
Bug Description
get_next_alarm() doesn't read the RTC_HOURS_ALARM field correctly.
- Bit 7 must be masked before conversion from BCD.
- Care must be taken to check the don't care condition before masking.
- The PM bit must be read from RTC_HOURS_ALARM, not from RTC_HOURS (as is done in convert_hour()).
Seen in commit e376a788ae13045
Revision history for this message
| Paolo Bonzini (bonzini) wrote | #1 |
| Changed in qemu: | |
| status: | New → Incomplete |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in qemu: | |
| status: | Incomplete → Expired |
To post a comment you must log in.
The problem is obviously there, but I tried pretty hard to make it fail and couldn't so it seems latent. If you can, please provide a patch to tests/rtc-test.c that shows the bug.