compilation error due to bug in savevm.c

Bug #1036987 reported by Evgeny Voevodin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QEMU
Fix Released
Undecided
Unassigned

Bug Description

Since

302dfbeb21fc5154c24ca50d296e865a3778c7da

Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

    For performance we are encoding long word at a time.
    For nzrun we use long-word-at-a-time NULL-detection tricks from strcmp():
    using ((lword - 0x0101010101010101) & (~lword) & 0x8080808080808080) test
    to find out if any byte in the long word is zero.

    Signed-off-by: Benoit Hudzia <email address hidden>
    Signed-off-by: Petter Svard <email address hidden>
    Signed-off-by: Aidan Shribman <email address hidden>
    Signed-off-by: Orit Wasserman <email address hidden>
    Signed-off-by: Eric Blake <email address hidden>

    Reviewed-by: Luiz Capitulino <email address hidden>
    Reviewed-by: Eric Blake <email address hidden>

 commit arrived into master barnch, I can't compile qemu at all:

savevm.c:2476:13: error: overflow in implicit constant conversion [-Werror=overflow]

Revision history for this message
Peter Maydell (pmaydell) wrote : Re: [Qemu-devel] [Bug 1036987] [NEW] compilation error due to bug in savevm.c

On 15 August 2012 08:44, Evgeny Voevodin <email address hidden> wrote:
> Since
>
> 302dfbeb21fc5154c24ca50d296e865a3778c7da
>
> Add xbzrle_encode_buffer and xbzrle_decode_buffer functions
> commit arrived into master barnch, I can't compile qemu at all:
>
> savevm.c:2476:13: error: overflow in implicit constant conversion
> [-Werror=overflow]

Fixed by this patch by Alex yesterday:
 http://patchwork.ozlabs.org/patch/177217/

(not yet in master)

-- PMM

Revision history for this message
agraf (agraf) wrote :
Changed in qemu:
status: New → Fix Committed
Revision history for this message
Thomas Huth (th-huth) wrote :
Changed in qemu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.