QBzr

Bazaar explorer crashes when in browse and I try to show annotate on a file

Bug #912344 reported by Jeff Wepman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Won't Fix
High
Unassigned
QBzr
Status tracked in Trunk
0.21
Fix Released
Medium
Alexander Belchenko
QBzr 0.21.3
Trunk
Fix Released
Medium
Alexander Belchenko
QBzr 0.22.0 "Alder"

Bug Description

The traceback is provided below:

bzr: ERROR: exceptions.AttributeError: 'int' object has no attribute 'encode'

Traceback (most recent call last):
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\uifactory.py", line 32, in decorate
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\treewidget.py", line 1865, in show_file_annotate
  File "bzrlib\lazy_import.pyo", line 129, in __call__
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\annotate.py", line 346, in __init__
  File "bzrlib\lazy_import.pyo", line 129, in __call__
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\widgets\tab_width_selector.py", line 58, in __init__
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\widgets\tab_width_selector.py", line 64, in triggered
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\annotate.py", line 343, in setTabStopWidth
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\util.py", line 1124, in get_set_tab_width_chars
  File "bzrlib\config.pyo", line 1404, in set_user_option
  File "bzrlib\config.pyo", line 1706, in set_option
  File "bzrlib\remote.pyo", line 3162, in set_option
  File "bzrlib\remote.pyo", line 3169, in _set_config_option
AttributeError: 'int' object has no attribute 'encode'

bzr 2.4.2 on python 2.6.6 (win32)
arguments: ['C:\\Program Files\\Bazaar\\bzrw.exe', 'qbrowse', 'bzr+ssh://192.168.130.139/srv/bzr/test', '-r-1']
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
  bzrtools C:\Program Files\Bazaar\plugins\bzrtools [2.4.1]
  changelog_merge C:\Program Files\Bazaar\plugins\changelog_merge [2.4.2]
  colo C:\Program Files\Bazaar\plugins\colo [0.3.1dev]
  explorer C:\Program Files\Bazaar\plugins\explorer [1.2.1]
  fastimport C:\Program Files\Bazaar\plugins\fastimport [0.12.0dev]
  launchpad C:\Program Files\Bazaar\plugins\launchpad [2.4.2]
  loom C:\Program Files\Bazaar\plugins\loom [2.2.1dev]
  netrc_credential_store C:\Program Files\Bazaar\plugins\netrc_credential_store [2.4.2]
  news_merge C:\Program Files\Bazaar\plugins\news_merge [2.4.2]
  pipeline C:\Program Files\Bazaar\plugins\pipeline [1.1.0]
  qbzr C:\Program Files\Bazaar\plugins\qbzr [0.21.1]
  rewrite C:\Program Files\Bazaar\plugins\rewrite [0.6.3dev]
  svn C:\Program Files\Bazaar\plugins\svn [1.1.0]
  upload C:\Program Files\Bazaar\plugins\upload [1.0.1dev]
  xmloutput C:\Program Files\Bazaar\plugins\xmloutput [0.8.7]

Tags: config hpss
Revision history for this message
Vincent Ladeuil (vila) wrote :

This a bug in RemoteBranchConfig._set_config_option which expects only strings as values for options.

The local config files use configobj directly which will stringify when needed.

@Jeff: The only workaround I can think of for you is to use a local branch to avoid the issue.

affects: qbzr → bzr
Changed in bzr:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Vincent Ladeuil (vila) wrote :

Bumping to high as there is no easy workaround and affect every config option that is not a string.

Changed in bzr:
importance: Medium → High
tags: added: config hpss
Revision history for this message
Jeff Wepman (jwepman) wrote : RE: [Bug 912344] Re: Bazaar explorer crashes when in browse and I try to show annotate on a file
Download full text (3.8 KiB)

Vincent,
Thank you for getting back with me on this.
Jeff

Jeffery A. Wepman
U.S. Dept. of Commerce
ITS.M
325 Broadway
Boulder, CO 80305
Telephone: 303.497.3165
email: <email address hidden>
________________________________________
From: <email address hidden> [<email address hidden>] On Behalf Of Vincent Ladeuil [<email address hidden>]
Sent: Thursday, January 05, 2012 9:11 AM
To: Jeff Wepman
Subject: [Bug 912344] Re: Bazaar explorer crashes when in browse and I try to show annotate on a file

This a bug in RemoteBranchConfig._set_config_option which expects only
strings as values for options.

The local config files use configobj directly which will stringify when
needed.

@Jeff: The only workaround I can think of for you is to use a local
branch to avoid the issue.

** Project changed: qbzr => bzr

** Changed in: bzr
   Importance: Undecided => Medium

** Changed in: bzr
       Status: New => Confirmed

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/912344

Title:
  Bazaar explorer crashes when in browse and I try to show annotate on a
  file

Status in Bazaar Version Control System:
  Confirmed

Bug description:
  The traceback is provided below:

  bzr: ERROR: exceptions.AttributeError: 'int' object has no attribute
  'encode'

  Traceback (most recent call last):
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\uifactory.py", line 32, in decorate
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\treewidget.py", line 1865, in show_file_annotate
    File "bzrlib\lazy_import.pyo", line 129, in __call__
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\annotate.py", line 346, in __init__
    File "bzrlib\lazy_import.pyo", line 129, in __call__
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\widgets\tab_width_selector.py", line 58, in __init__
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\widgets\tab_width_selector.py", line 64, in triggered
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\annotate.py", line 343, in setTabStopWidth
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\util.py", line 1124, in get_set_tab_width_chars
    File "bzrlib\config.pyo", line 1404, in set_user_option
    File "bzrlib\config.pyo", line 1706, in set_option
    File "bzrlib\remote.pyo", line 3162, in set_option
    File "bzrlib\remote.pyo", line 3169, in _set_config_option
  AttributeError: 'int' object has no attribute 'encode'

  bzr 2.4.2 on python 2.6.6 (win32)
  arguments: ['C:\\Program Files\\Bazaar\\bzrw.exe', 'qbrowse', 'bzr+ssh://192.168.130.139/srv/bzr/test', '-r-1']
  encoding: 'cp1252', fsenc: 'mbcs', lang: None
  plugins:
    bzrtools C:\Program Files\Bazaar\plugins\bzrtools [2.4.1]
    changelog_merge C:\Program Files\Bazaar\plugins\changelog_merge [2.4.2]
    colo C:\Program Files\Bazaar\plugins\colo [0.3.1dev]
    explorer C:\Program Files\Bazaar\plugins\explorer [1.2.1]
    fastimport C:\Program Files\Bazaar\plugins\fastimport [0.12.0dev]
    launchpad C:\Program Files\Bazaar\plugins\launchpad [2.4.2]
    loom C:\Program Files\Bazaar\plugins\loom [2.2.1dev]
    netrc_creden...

Read more...

Revision history for this message
Alexander Belchenko (bialix) wrote :

We can make a workaround in QBzr code itself.

Revision history for this message
Alexander Belchenko (bialix) wrote :

Jeff, attached is simple workaround for qbzr.

Revision history for this message
Jeff Wepman (jwepman) wrote :
Download full text (3.6 KiB)

Alexander,
Thank you for the workaround.
Jeff

Jeffery A. Wepman
U.S. Dept. of Commerce
ITS.M
325 Broadway
Boulder, CO 80305
Telephone: 303.497.3165
email: <email address hidden>
________________________________________
From: <email address hidden> [<email address hidden>] On Behalf Of Alexander Belchenko [<email address hidden>]
Sent: Friday, January 06, 2012 4:43 AM
To: Jeff Wepman
Subject: [Bug 912344] Re: Bazaar explorer crashes when in browse and I try to show annotate on a file

Jeff, attached is simple workaround for qbzr.

** Patch added: "bug-912344-workaround.diff"
   https://bugs.launchpad.net/bzr/+bug/912344/+attachment/2659855/+files/bug-912344-workaround.diff

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/912344

Title:
  Bazaar explorer crashes when in browse and I try to show annotate on a
  file

Status in Bazaar Version Control System:
  Confirmed

Bug description:
  The traceback is provided below:

  bzr: ERROR: exceptions.AttributeError: 'int' object has no attribute
  'encode'

  Traceback (most recent call last):
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\uifactory.py", line 32, in decorate
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\treewidget.py", line 1865, in show_file_annotate
    File "bzrlib\lazy_import.pyo", line 129, in __call__
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\annotate.py", line 346, in __init__
    File "bzrlib\lazy_import.pyo", line 129, in __call__
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\widgets\tab_width_selector.py", line 58, in __init__
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\widgets\tab_width_selector.py", line 64, in triggered
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\annotate.py", line 343, in setTabStopWidth
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\util.py", line 1124, in get_set_tab_width_chars
    File "bzrlib\config.pyo", line 1404, in set_user_option
    File "bzrlib\config.pyo", line 1706, in set_option
    File "bzrlib\remote.pyo", line 3162, in set_option
    File "bzrlib\remote.pyo", line 3169, in _set_config_option
  AttributeError: 'int' object has no attribute 'encode'

  bzr 2.4.2 on python 2.6.6 (win32)
  arguments: ['C:\\Program Files\\Bazaar\\bzrw.exe', 'qbrowse', 'bzr+ssh://192.168.130.139/srv/bzr/test', '-r-1']
  encoding: 'cp1252', fsenc: 'mbcs', lang: None
  plugins:
    bzrtools C:\Program Files\Bazaar\plugins\bzrtools [2.4.1]
    changelog_merge C:\Program Files\Bazaar\plugins\changelog_merge [2.4.2]
    colo C:\Program Files\Bazaar\plugins\colo [0.3.1dev]
    explorer C:\Program Files\Bazaar\plugins\explorer [1.2.1]
    fastimport C:\Program Files\Bazaar\plugins\fastimport [0.12.0dev]
    launchpad C:\Program Files\Bazaar\plugins\launchpad [2.4.2]
    loom C:\Program Files\Bazaar\plugins\loom [2.2.1dev]
    netrc_credential_store C:\Program Files\Bazaar\plugins\netrc_credential_store [2.4.2]
    news_merge C:\Program Files\Bazaar\plugins\news_merge [2.4.2]
    pipeline C:\Program Files\Bazaar\plugins\pipeline [1.1.0]
    qbzr ...

Read more...

Revision history for this message
Alexander Belchenko (bialix) wrote :

Jeff, have you tested my workaround? Did it help you?

Changed in qbzr:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Alexander Belchenko (bialix)
Revision history for this message
Jeff Wepman (jwepman) wrote :
Download full text (3.8 KiB)

Alexander,
I did try the workaround and it seems to now work very well. Thank you very much! I appreciate your efforts.
Jeff

Jeffery A. Wepman
U.S. Dept. of Commerce
ITS.M
325 Broadway
Boulder, CO 80305
Telephone: 303.497.3165
email: <email address hidden>
________________________________________
From: <email address hidden> [<email address hidden>] On Behalf Of Alexander Belchenko [<email address hidden>]
Sent: Wednesday, January 25, 2012 3:09 AM
To: Jeff Wepman
Subject: [Bug 912344] Re: Bazaar explorer crashes when in browse and I try to show annotate on a file

Jeff, have you tested my workaround? Did it help you?

** Also affects: qbzr
   Importance: Undecided
       Status: New

** Changed in: qbzr
       Status: New => Confirmed

** Changed in: qbzr
   Importance: Undecided => Medium

** Changed in: qbzr
     Assignee: (unassigned) => Alexander Belchenko (bialix)

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/912344

Title:
  Bazaar explorer crashes when in browse and I try to show annotate on a
  file

Status in Bazaar Version Control System:
  Confirmed
Status in Qt frontend for Bazaar:
  Confirmed

Bug description:
  The traceback is provided below:

  bzr: ERROR: exceptions.AttributeError: 'int' object has no attribute
  'encode'

  Traceback (most recent call last):
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\uifactory.py", line 32, in decorate
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\treewidget.py", line 1865, in show_file_annotate
    File "bzrlib\lazy_import.pyo", line 129, in __call__
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\annotate.py", line 346, in __init__
    File "bzrlib\lazy_import.pyo", line 129, in __call__
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\widgets\tab_width_selector.py", line 58, in __init__
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\widgets\tab_width_selector.py", line 64, in triggered
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\annotate.py", line 343, in setTabStopWidth
    File "C:/Program Files/Bazaar/plugins\qbzr\lib\util.py", line 1124, in get_set_tab_width_chars
    File "bzrlib\config.pyo", line 1404, in set_user_option
    File "bzrlib\config.pyo", line 1706, in set_option
    File "bzrlib\remote.pyo", line 3162, in set_option
    File "bzrlib\remote.pyo", line 3169, in _set_config_option
  AttributeError: 'int' object has no attribute 'encode'

  bzr 2.4.2 on python 2.6.6 (win32)
  arguments: ['C:\\Program Files\\Bazaar\\bzrw.exe', 'qbrowse', 'bzr+ssh://192.168.130.139/srv/bzr/test', '-r-1']
  encoding: 'cp1252', fsenc: 'mbcs', lang: None
  plugins:
    bzrtools C:\Program Files\Bazaar\plugins\bzrtools [2.4.1]
    changelog_merge C:\Program Files\Bazaar\plugins\changelog_merge [2.4.2]
    colo C:\Program Files\Bazaar\plugins\colo [0.3.1dev]
    explorer C:\Program Files\Bazaar\plugins\explorer [1.2.1]
    fastimport C:\Program Files\Bazaar\plugins\fastimport [0.12.0dev]
    launchpad C:\Program Files\Bazaar\plugins\launchpad [2.4.2]
    loom C:\Program Files\Bazaar\plugins\loom [2.2.1dev]
    netrc_credent...

Read more...

Revision history for this message
Vincent Ladeuil (vila) wrote :

bzr is still not immune to the defect but since we had no other reports and qbzr works around the issue I think we'b better finish migrating to the new config than fixing edge cases in the old one.

Changed in bzr:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.