diffviewer crash when mixed line endings: IndexError: pop from empty list

Bug #839053 reported by btb on 2011-09-01
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
QBzr
Critical
Unassigned

Bug Description

If repository contain a mixed unix and windows-style line endings, the difference viewer crashes.

bzr: ERROR: exceptions.IndexError: pop from empty list

Traceback (most recent call last):
  File "G:/progs/Bazaar/plugins\qbzr\lib\trace.py", line 365, in reports_exception_decorate
  File "G:/progs/Bazaar/plugins\qbzr\lib\diffwindow.py", line 534, in initial_load
  File "bzrlib\cleanup.pyo", line 131, in run
  File "bzrlib\cleanup.pyo", line 165, in _do_with_cleanups
  File "G:/progs/Bazaar/plugins\qbzr\lib\diffwindow.py", line 548, in _initial_load
  File "G:/progs/Bazaar/plugins\qbzr\lib\diffwindow.py", line 641, in load_diff
  File "G:/progs/Bazaar/plugins\qbzr\lib\diffview.py", line 439, in append_diff
  File "G:/progs/Bazaar/plugins\qbzr\lib\diffview.py", line 388, in insertIxsWithChangesHighlighted
IndexError: pop from empty list

bzr 2.4.0 on python 2.6.6 (win32)
arguments: ['g:\\progs\\Bazaar\\bzr.exe', 'explore']
encoding: 'cp1250', fsenc: 'mbcs', lang: None
plugins:
  bzrtools G:\progs\Bazaar\plugins\bzrtools [2.4.0]
  changelog_merge G:\progs\Bazaar\plugins\changelog_merge [2.4.0]
  colo G:\progs\Bazaar\plugins\colo [0.3.1dev]
  explorer G:\progs\Bazaar\plugins\explorer [1.2.1]
  fastimport G:\progs\Bazaar\plugins\fastimport [0.12.0dev]
  launchpad G:\progs\Bazaar\plugins\launchpad [2.4.0]
  loom G:\progs\Bazaar\plugins\loom [2.2.1dev]
  netrc_credential_store G:\progs\Bazaar\plugins\netrc_credential_store [2.4.0]
  news_merge G:\progs\Bazaar\plugins\news_merge [2.4.0]
  pipeline G:\progs\Bazaar\plugins\pipeline [1.1.0]
  qbzr G:\progs\Bazaar\plugins\qbzr [0.21.1]
  rewrite G:\progs\Bazaar\plugins\rewrite [0.6.3dev]
  svn G:\progs\Bazaar\plugins\svn [1.1.0]
  upload G:\progs\Bazaar\plugins\upload [1.0.1dev]
  xmloutput G:\progs\Bazaar\plugins\xmloutput [0.8.7]

affects: bzr-explorer → qbzr

> If repository contain a mixed unix and windows-style line endings, the
> difference viewer crashes.
>
> bzr: ERROR: exceptions.IndexError: pop from empty list

I'm sure it's dupe, but thank you for bug report anyway.

The file in repo contains \n and \r\n lineend, the working file \n only.
Diffviewer crashes on windows (1.2.1) and linux (1.0.0).

btb пишет:
> The file in repo contains \n and \r\n lineend, the working file \n only.
> Diffviewer crashes on windows (1.2.1) and linux (1.0.0).
>
> ** Attachment added: "test.zip"
> https://bugs.launchpad.net/qbzr/+bug/839053/+attachment/2343143/+files/test.zip

Many thanks for testing repo!

tags: added: qdiff with-real-example
Changed in qbzr:
status: New → Confirmed
importance: Undecided → Critical
summary: - diffviewer crash when mixed line endings
+ diffviewer crash when mixed line endings: IndexError: pop from empty
+ list
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments