qlog@Windows7: color of text of highlighted revision is hard to read

Bug #790590 reported by Alexander Belchenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
High
Alexander Belchenko

Bug Description

As it could be seen on the attached image in Windows7 selected revision has light blue background and our white text is really hard to read.

As I remember we control the color of the text manually, perhaps we should add some special support for either Windows7 or for such highlight color, or make it configurable.

Tags: qlog windows7

Related branches

Revision history for this message
Alexander Belchenko (bialix) wrote :
Revision history for this message
Alexander Belchenko (bialix) wrote :

Possible related to Aero Windows Style.

Revision history for this message
Alexander Belchenko (bialix) wrote :

http://groups.google.com/group/ru_bzr/browse_thread/thread/36598ad3a34b3d8f#

SO in fact only revno column and message column have these problem. As I remember for both those columns we have custom drawing delegates. So I suppose we should improve them to use the system default colors instead of forcing white text always.

Changed in qbzr:
status: Confirmed → In Progress
assignee: nobody → Alexander Belchenko (bialix)
Revision history for this message
Alexander Belchenko (bialix) wrote :

I've tried to find out the solution to fix this. But it seems unfortunately PyQt does not provide enough information to help us properly determine text color for selected row if Aero interface is enabled in Windows (I believe it's related to Vista/7 only).
So I've made a simple hack/workaround to force dark text color if aero is enabled.

Please, who can test this solution on Vista/7 with Aero enabled and disabled, tell me whether it works correctly in all cases.
Testing on Windows 8 is also interesting.

The proposed fix available in lp:qbzr revno.1505.

Changed in qbzr:
milestone: none → 0.23.1
Revision history for this message
Alexander Belchenko (bialix) wrote :

I've added another workaround for win8 where PyQt does not support visual styles well.

Changed in qbzr:
status: In Progress → Fix Released
Revision history for this message
Stas Kalashnikov (halega) wrote :

It fixed the problem with colors in Windows 7. The colors are fine in Windows 7 without styles and in Windows 8 too.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.