qlog breaks with ghosts revisions

[Jelmer Vernooij]

bzr qlog currently breaks when used on a branch that has ghosts in its mainline. An example of such a project is solfege:

http://solfege.org/bzr/solfege.dev/

bzr: ERROR: bzrlib.plugins.qbzr.lib.loggraphviz.GhostRevisionError: {Arch-1:<email address hidden>%solfege--unstable--3.1--version-0} is a ghost.

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/util.py", line 884, in run_in_loading_queue
    f(*args, **kargs)
  File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/uifactory.py", line 32, in decorate
    r = f(*args, **kargs)
  File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/log.py", line 629, in load_delta
    repos = [gv.get_revid_branch(revid).repository for revid in revids]
  File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/loggraphviz.py", line 1021, in get_revid_branch
    return self.get_revid_branch_info(revid).branch
  File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/loggraphviz.py", line 1014, in get_revid_branch_info
    raise GhostRevisionError(revid)
GhostRevisionError: {Arch-1:<email address hidden>%solfege--unstable--3.1--version-0} is a ghost.

[Alexander Belchenko (bialix)]

It seems qlog does not know what to do about ghost on mainline, or ghost revisions in general.

[Alexander Belchenko (bialix)]

Well, I've tried to run qlog over solfege repo, and it does not crashes while I've just scrolled the history. But when I've tried to search for the revision-id Arch-1:<email address hidden>%solfege--unstable--3.1--version-0 qlog suddenly crashed.

[Alexander Belchenko (bialix)]

And BTW:

C:\Temp\solfege.dev>bzr log -r revid:Arch-1:<email address hidden>%solfege--unstable--3.1--version-0
bzr: ERROR: Requested revision: 'revid:Arch-1:<email address hidden>%solfege--unstable--3.1--version-0' does not exist in br
nch: file:///C:/Temp/solfege.dev/

bzr itself unable to show the log for ghosts. What qlog should do about ghosts then?

[Jelmer Vernooij (jelmer)]

There is a separate open bug about bzr log having trouble with ghosts in mainline.

[Jelmer Vernooij (jelmer)]

the qlog window disappears here if I go to the first revision in qlog, and prints a backtrace:

bzr: ERROR: bzrlib.plugins.qbzr.lib.loggraphviz.GhostRevisionError: {Arch-1:<email address hidden>%solfege--unstable--3.1--version-0} is a ghost.

Traceback (most recent call last):
  File "/home/jelmer/.bazaar/plugins/qbzr/lib/util.py", line 898, in run_in_loading_queue
    f(*args, **kargs)
  File "/home/jelmer/.bazaar/plugins/qbzr/lib/uifactory.py", line 32, in decorate
    r = f(*args, **kargs)
  File "/home/jelmer/.bazaar/plugins/qbzr/lib/log.py", line 629, in load_delta
    repos = [gv.get_revid_branch(revid).repository for revid in revids]
  File "/home/jelmer/.bazaar/plugins/qbzr/lib/loggraphviz.py", line 1021, in get_revid_branch
    return self.get_revid_branch_info(revid).branch
  File "/home/jelmer/.bazaar/plugins/qbzr/lib/loggraphviz.py", line 1014, in get_revid_branch_info
    raise GhostRevisionError(revid)
GhostRevisionError: {Arch-1:<email address hidden>%solfege--unstable--3.1--version-0} is a ghost.

You can report this problem to Bazaar's developers by running
    apport-bug /var/crash/bzr.1000.2011-05-12T11:40.crash
if a bug-reporting window does not automatically appear.

[Alexander Belchenko (bialix)]

Jelmer, I've scrolled down to the first revision and qlog has not crashed. I suppose it'll crash when I actually click on that revision.

[Alexander Belchenko (bialix)]

Yes, you have to click on the revision.

We should fix that.