qlog: Delta loading crashes on GhostRevisionError

Bug #638422 reported by Kiselev Anton
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
QBzr
Confirmed
Medium
Unassigned

Bug Description

I was learning how to use bzr. created local test svn repository, made some commits both with svn and bzr(with bzr local-commits and bzr branching ). commited all changes to svn. run bzr checkout; bzr qlog. qlog tree has sub-entities with no caption, double click on it leads to an error.
using Windows XP, bzr standalone

===
bzr: ERROR: bzrlib.plugins.qbzr.lib.loggraphprovider.GhostRevisionError: {<email address hidden>} is a ghost.

Traceback (most recent call last):
  File "I:/wpf/plugins\qbzr\lib\util.py", line 856, in decorate
  File "I:/wpf/plugins\qbzr\lib\util.py", line 868, in run_in_loading_queue
  File "I:/wpf/plugins\qbzr\lib\uifactory.py", line 32, in decorate
  File "I:/wpf/plugins\qbzr\lib\log.py", line 468, in load_delta
  File "I:/wpf/plugins\qbzr\lib\loggraphprovider.py", line 1659, in get_revid_branch
  File "I:/wpf/plugins\qbzr\lib\loggraphprovider.py", line 1652, in get_revid_branch_info
GhostRevisionError: {<email address hidden>} is a ghost.

bzr 2.2.0 on python 2.6.4 (win32)
arguments: ['I:\\wpf\\bzr.EXE', 'qlog']
encoding: 'cp1251', fsenc: 'mbcs', lang: None
plugins:
  bzrtools I:\wpf\plugins\bzrtools [2.2.0]
  colo I:\wpf\plugins\colo [0.1.0]
  explorer I:\wpf\plugins\explorer [1.1b1]
  fastimport I:\wpf\plugins\fastimport [0.9.0dev]
  launchpad I:\wpf\plugins\launchpad [2.2.0]
  loom I:\wpf\plugins\loom [2.2.1dev]
  netrc_credential_store I:\wpf\plugins\netrc_credential_store [2.2.0]
  news_merge I:\wpf\plugins\news_merge [2.2.0]
  pipeline I:\wpf\plugins\pipeline [unknown]
  qbzr I:\wpf\plugins\qbzr [0.19.0]
  rewrite I:\wpf\plugins\rewrite [0.6.0]
  svn I:\wpf\plugins\svn [1.0.3]
  upload I:\wpf\plugins\upload [1.0.0dev]
  xmloutput I:\wpf\plugins\xmloutput [0.8.6]

Revision history for this message
Gary van der Merwe (garyvdm) wrote :

This should be easy to fix. We should quietly ignore GhostRevisionErrors in the delta loading.

summary: - qbzr crashes qlog ( with bzr-svn )
+ qlog: Delta loading crashes on GhostRevisionError
Changed in qbzr:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Alexander Belchenko (bialix) wrote :

Gary, I think we should show some explanation text for ghost revision, not just silently ignore it.

Revision history for this message
Gary van der Merwe (garyvdm) wrote : Re: [Bug 638422] Re: qlog: Delta loading crashes on GhostRevisionError

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 15/09/2010 08:24, Alexander Belchenko wrote:
> Gary, I think we should show some explanation text for ghost revision,
> not just silently ignore it.

I agree. We could show this in the revision browser. Something like:

Revision: xxx.x.x revid:xxxx@xxxxx-xxxxxxxxxxxxx
Children: xxx

This revision is a ghost. We have a record of it, but it is not in the
repository. You can try fix this by running bzr fetch-ghosts.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyQb2MACgkQd/3EdwGKOh10AgCeJDW2FHNaPswmP0DGFA5V8qsd
cvwAnjC4oIdDF8Tbd7Aum90dtZcL56F8
=RfVm
-----END PGP SIGNATURE-----

Revision history for this message
Alexander Belchenko (bialix) wrote :

Gary van der Merwe пишет:
> On 15/09/2010 08:24, Alexander Belchenko wrote:
>> Gary, I think we should show some explanation text for ghost revision,
>> not just silently ignore it.
>
> I agree. We could show this in the revision browser. Something like:
>
> Revision: xxx.x.x revid:xxxx@xxxxx-xxxxxxxxxxxxx
> Children: xxx
>
> This revision is a ghost. We have a record of it, but it is not in the
> repository. You can try fix this by running bzr fetch-ghosts.

+1

--
All the dude wanted was his rug back

Revision history for this message
André Bachmann (andrebachmann-dd) wrote :

I had the same error a minute ago if I copy a foreign branch of a project in another project. Qlog closes itself, and in .bzr.log I also have this error message about an GhostRevisionError:

...
12.036 Traceback (most recent call last):
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\qbzr\lib\util.py", line 908, in run_in_loading_queue
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\qbzr\lib\uifactory.py", line 32, in decorate
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\qbzr\lib\log.py", line 633, in load_delta
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\qbzr\lib\loggraphviz.py", line 1021, in get_revid_branch
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\qbzr\lib\loggraphviz.py", line 1014, in get_revid_branch_info
GhostRevisionError: {<email address hidden>} is a ghost.

12.059 couldn't find apport bug-reporting library: No module named apport
12.082 Traceback (most recent call last):
  File "bzrlib\plugin.pyo", line 553, in _get__version__
  File "bzrlib\__init__.pyo", line 101, in _format_version_tuple
IndexError: tuple index out of range

12.082 Traceback (most recent call last):
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\qbzr\lib\util.py", line 908, in run_in_loading_queue
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\qbzr\lib\uifactory.py", line 32, in decorate
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\qbzr\lib\log.py", line 633, in load_delta
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\qbzr\lib\loggraphviz.py", line 1021, in get_revid_branch
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\qbzr\lib\loggraphviz.py", line 1014, in get_revid_branch_info
GhostRevisionError: {<email address hidden>} is a ghost.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.