qannotate: clicking on parent link in revision view do nothing

[Alexander Belchenko]

It seems like misfeature for me. We either should not show the links to revisions which are not in the graph, or do something when we click on such link. My use case was to get annotation of the file before big refactoring. So my natural reaction was to find revision where refactoring has been done and use its left-hand parent to get previous annotation. Instead I've just got an empty revision info view. This is confusing.

[Gary van der Merwe (garyvdm)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/09/2010 10:59, Alexander Belchenko wrote:
> It seems like misfeature for me. We either should not show the links to
> revisions which are not in the graph, or do something when we click on
> such link. My use case was to get annotation of the file before big
> refactoring. So my natural reaction was to find revision where
> refactoring has been done and use its left-hand parent to get previous
> annotation. Instead I've just got an empty revision info view. This is
> confusing.

What normally happens is when you click on a link to a rev, it selects
the revision in the log view, and when the selection in the log view
changes, the revision browser is updated.

But parent is probably filtered out, because it does not touch file
beaning annotated. So it can't select it in log view, an so the revision
browser is not updated.

We have 2 options on how to fix this:

1. In the link handler, if the revision is filtered out in the log view,
update the revision browser directly.

2. If the revision is filtered out in the log view, show it.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyAnQIACgkQd/3EdwGKOh0+1ACgwuVeen21Jz0TqyWWrnsSZ/9B
PjMAoKQloYHmY6zGCyWZdfWzEhrQW5Jl
=h/EF
-----END PGP SIGNATURE-----