TooManyConcurrentRequests when saving from editor spawned by bzr-explorer

Bug #622474 reported by Martitza on 2010-08-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Explorer
High
Unassigned
QBzr
High
Unassigned

Bug Description

1. Launch Bazaar Explorer
2. Open an existing working tree (mine is a checkout, but branches might show the same problem)
3. Select a text file in the working tree browser.
4. Click the icon (under the WT) to Edit the file. ==> Notepad opens on Windows
5. Change some text to mark file as dirty in Notepad.
6. Press Ctrl-S to save ==> get the attached traceback

7. Ignore the error.
8. Notice that subsequent saves work without error.
9. Close and reopen the text file.
10. Notice that subsequent edit+save works without error but that saving is noticeable slow (hourglass appears for ~1 second)
11. Commit change.
12. Go back to steps 3..6. Notice that the error reoccurs.

Note that this trace appears in a dialog box but does *not* appear in the .bzr.log.
It looks like it may actually be local to bzr explorer...

Martitza (martitzam) wrote :
summary: - TooManyConcurrentRequests in editor launched by bzr-explorer
+ TooManyConcurrentRequests when saving from editor spawned by bzr-
+ explorer
Alexander Belchenko (bialix) wrote :

bzr: ERROR: bzrlib.errors.TooManyConcurrentRequests: The medium 'SmartSSHClientMedium(bzr+ssh://<email address hidden>/)' has reached its concurrent request limit. Be sure to finish_writing and finish_reading on the currently open request.

Traceback (most recent call last):
  File "D:/Program Files/Bazaar/plugins\explorer\lib\explorer.py", line 1237, in _file_edited_handler
  File "D:/Program Files/Bazaar/plugins\explorer\lib\explorer.py", line 1689, in do_refresh
  File "D:/Program Files/Bazaar/plugins\explorer\lib\explorer.py", line 667, in changed_view
  File "D:/Program Files/Bazaar/plugins\explorer\lib\wt_browser.py", line 65, in set_tree
  File "D:/Program Files/Bazaar/plugins\explorer\lib\wt_browser.py", line 469, in set_tree
  File "D:/Program Files/Bazaar/plugins\explorer\lib\wt_browser.py", line 691, in set_tree
  File "D:/Program Files/Bazaar/plugins\qbzr\lib\treewidget.py", line 1446, in set_tree
  File "bzrlib\decorators.pyo", line 140, in read_locked
  File "bzrlib\branch.pyo", line 970, in last_revision_info
  File "bzrlib\remote.pyo", line 2546, in _last_revision_info
  File "bzrlib\remote.pyo", line 55, in _call
  File "bzrlib\smart\client.pyo", line 132, in call
  File "bzrlib\smart\client.pyo", line 145, in call_expecting_body
  File "bzrlib\smart\client.pyo", line 79, in _call_and_read_response
  File "bzrlib\smart\client.pyo", line 45, in _send_request
  File "bzrlib\smart\client.pyo", line 115, in _construct_protocol
  File "bzrlib\smart\medium.pyo", line 711, in get_request
  File "bzrlib\smart\medium.pyo", line 969, in __init__
TooManyConcurrentRequests: The medium 'SmartSSHClientMedium(bzr+ssh://<email address hidden>/)' has reached its concurrent request limit. Be sure to finish_writing and finish_reading on the currently open request.

bzr 2.2.0 on python 2.6.4 (win32)
arguments: ['D:\\Program Files\\Bazaar\\bzrw.exe', 'explorer']
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
  bzrtools D:\Program Files\Bazaar\plugins\bzrtools [2.2.0]
  colo D:\Program Files\Bazaar\plugins\colo [0.1.0]
  explorer D:\Program Files\Bazaar\plugins\explorer [1.1b1]
  extmerge D:\Program Files\Bazaar\plugins\extmerge [unknown]
  fastimport D:\Program Files\Bazaar\plugins\fastimport [0.9.0dev]
  launchpad D:\Program Files\Bazaar\plugins\launchpad [2.2.0]
  loom D:\Program Files\Bazaar\plugins\loom [2.2.1dev]
  netrc_credential_store D:\Program Files\Bazaar\plugins\netrc_credential_store [2.2.0]
  news_merge D:\Program Files\Bazaar\plugins\news_merge [2.2.0]
  pipeline D:\Program Files\Bazaar\plugins\pipeline [unknown]
  qbzr D:\Program Files\Bazaar\plugins\qbzr [0.19.0]
  rewrite D:\Program Files\Bazaar\plugins\rewrite [0.6.0]
  svn D:\Program Files\Bazaar\plugins\svn [1.0.3]
  upload D:\Program Files\Bazaar\plugins\upload [1.0.0dev]
  xmloutput D:\Program Files\Bazaar\plugins\xmloutput [0.8.6]

tags: added: smart-server treewidget
Alexander Belchenko (bialix) wrote :

Martitza, do you have lightweight checkout?

As workaround you can change the working tree browser to classic style: main menu -> Tools -> Options -> Working Tree -> select "classic" instead of "qbrowse".

Yes. I am experimenting with lightweight cbeckouts. (Turns out they
mighT be ok fpr us if we organize our repos a little differently.). I
will try your suggestion today.

On 8/22/10, Alexander Belchenko <email address hidden> wrote:
> Martitza, do you have lightweight checkout?
>
> As workaround you can change the working tree browser to classic style:
> main menu -> Tools -> Options -> Working Tree -> select "classic"
> instead of "qbrowse".
>
> --
> TooManyConcurrentRequests when saving from editor spawned by bzr-explorer
> https://bugs.launchpad.net/bugs/622474
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Bazaar Explorer: New
> Status in Qt frontend for Bazaar: New
>
> Bug description:
>
> 1. Launch Bazaar Explorer
> 2. Open an existing working tree (mine is a checkout, but branches might
> show the same problem)
> 3. Select a text file in the working tree browser.
> 4. Click the icon (under the WT) to Edit the file. ==> Notepad opens on
> Windows
> 5. Change some text to mark file as dirty in Notepad.
> 6. Press Ctrl-S to save ==> get the attached traceback
>
> 7. Ignore the error.
> 8. Notice that subsequent saves work without error.
> 9. Close and reopen the text file.
> 10. Notice that subsequent edit+save works without error but that saving is
> noticeable slow (hourglass appears for ~1 second)
> 11. Commit change.
> 12. Go back to steps 3..6. Notice that the error reoccurs.
>
> Note that this trace appears in a dialog box but does *not* appear in the
> .bzr.log.
> It looks like it may actually be local to bzr explorer...
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/bzr-explorer/+bug/622474/+subscribe
>

Martitza пишет:
> Yes. I am experimenting with lightweight cbeckouts. (Turns out they
> mighT be ok fpr us if we organize our repos a little differently.). I
> will try your suggestion today.

Another suggestion: use heavyweight checkouts, aka bound branches
instead of light branches, if you have enough room on your disk to
hold all your history.

Ok! Instead of my usual "huge" test branch, I've been working with a tiny
branch with only three files. So...

Sure enough, bound branches do not exhibit the Too ManyConcurrentRequests
bug.

So far, only checkouts are showing the TooManyConcurrentRequests bug.

To be clear: the bug occurs on Windows XP using bzr+ssh with bzr 2.2.0 and
bzr-explorer 1.1b1 for lightweight checkouts only.

I have not seen the bug on ubuntu (I have looked) but I am still running bzr
2.1.x on my lucid boxes.

~M

On Mon, Aug 23, 2010 at 11:48 AM, Alexander Belchenko <email address hidden>wrote:

> Martitza пишет:
> > Yes. I am experimenting with lightweight cbeckouts. (Turns out they
> > mighT be ok fpr us if we organize our repos a little differently.). I
> > will try your suggestion today.
>
> Another suggestion: use heavyweight checkouts, aka bound branches
> instead of light branches, if you have enough room on your disk to
> hold all your history.
>
> --
> TooManyConcurrentRequests when saving from editor spawned by bzr-explorer
> https://bugs.launchpad.net/bugs/622474
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Bazaar Explorer: New
> Status in Qt frontend for Bazaar: New
>
> Bug description:
>
> 1. Launch Bazaar Explorer
> 2. Open an existing working tree (mine is a checkout, but branches might
> show the same problem)
> 3. Select a text file in the working tree browser.
> 4. Click the icon (under the WT) to Edit the file. ==> Notepad opens on
> Windows
> 5. Change some text to mark file as dirty in Notepad.
> 6. Press Ctrl-S to save ==> get the attached traceback
>
> 7. Ignore the error.
> 8. Notice that subsequent saves work without error.
> 9. Close and reopen the text file.
> 10. Notice that subsequent edit+save works without error but that saving is
> noticeable slow (hourglass appears for ~1 second)
> 11. Commit change.
> 12. Go back to steps 3..6. Notice that the error reoccurs.
>
> Note that this trace appears in a dialog box but does *not* appear in the
> .bzr.log.
> It looks like it may actually be local to bzr explorer...
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/bzr-explorer/+bug/622474/+subscribe
>

Martitza (martitzam) wrote :

Update and correction (cf. comment #6): I *do* see this bug on Ubuntu.

Changed in bzr-explorer:
status: New → Confirmed
importance: Undecided → High
Changed in qbzr:
status: New → Confirmed
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments