qlog: Crashes on collapsing a node with 'NoneType' object is not iterable

Bug #470152 reported by Craig Hewetson
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
Critical
Gary van der Merwe

Bug Description

Open qlog in qbzr branch.

Expand revision 1036.
Select any node within expanded revision node. (eg: 931.1.48)
Then collapse revision 1036.

Result:
bzr: ERROR: exceptions.TypeError: 'NoneType' object is not iterable

Traceback (most recent call last):
  File "/home/craig/.bazaar/plugins/qbzr/lib/util.py", line 1018, in decorate
    run_in_loading_queue(f, *args, **kargs)
  File "/home/craig/.bazaar/plugins/qbzr/lib/util.py", line 1030, in run_in_loading_queue
    f(*args, **kargs)
  File "/home/craig/.bazaar/plugins/qbzr/lib/uifactory.py", line 32, in decorate
    r = f(*args, **kargs)
  File "/home/craig/.bazaar/plugins/qbzr/lib/log.py", line 516, in load_delta
    repos = [gp.get_revid_branch(revid).repository for revid in revids]
TypeError: 'NoneType' object is not iterable

Related branches

Changed in qbzr:
importance: Undecided → Critical
status: New → Confirmed
summary: - qlog crashes on collapsing a node.
+ qlog: Crashes on collapsing a node with 'NoneType' object is not
+ iterable
Changed in qbzr:
assignee: nobody → Gary van der Merwe (garyvdm)
milestone: none → 0.16
status: Confirmed → Fix Released
Revision history for this message
Craig Hewetson (craighewetson-deactivatedaccount) wrote : Re: [Bug 470152] Re: qlog: Crashes on collapsing a node with 'NoneType' object is not iterable

I still get the error.
Looking at the code on line 519 it seems that
revids might contain a element of NoneType.

Revision history for this message
Gary van der Merwe (garyvdm) wrote :

My fix was bad. Luks has fixed it now.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.