qlog: text unreadable when selected

[Craig Hewetson]

Running default vista theme.
Select a revision in qlog.

[Craig Hewetson (craighewetson-deactivatedaccount)]

any workarounds for this problem?

[Alexander Belchenko (bialix)]

wow. weird.

[Alexander Belchenko (bialix)]

Is it using standalone windows installer?

[Craig Hewetson (craighewetson-deactivatedaccount)]

>>Is it using standalone windows installer?
Yes

[Alexander Belchenko (bialix)]

Craig, I have no idea how to workaround this. qlog using custom rendering code to draw graph and write text in the same time. This is the root of problems with colors. It should be fixed again in Vista-aware style.

Does qlog --no-graph is also affected by this problem?

[Alexander Belchenko (bialix)]

Or maybe we should force old windows style behavior (aka windows xp) for qlog. I'm not sure is it possible, I have no access to Vista PC.

[Gary van der Merwe (garyvdm)]

It was probably introduced by revs 969 and 970. That change was made so the it renders the highlight style correctly. (It use to look like this before: http://launchpadlibrarian.net/31887401/QBZRLog_BadButton.jpg )

I don't have a copy of vista, so I'm hoping you can help me debug this.

The color for both columns is decided in lib.revtreeview.StyledItemDelegate.get_text_color
http://bazaar.launchpad.net/~qbzr-dev/qbzr/trunk/annotate/head:/lib/revtreeview.py#L151
May be you can check that It is following the correct paths.

In the meantime, I'm going to read the qt code to see if there is any thing special that it does for vista.

P.s. This bug can also be seen here: http://1.bp.blogspot.com/_ulqEWRozxIE/StdFMdOCwjI/AAAAAAAAAAc/VtRwBFl-HtE/s1600-h/2.0.1and2.1.0b1.png

[Craig Hewetson (craighewetson-deactivatedaccount)]

Can't we use a generic way to render the text when selected. Something like
XOR color invert?

Well test the no-graph option soon

[Gary van der Merwe (garyvdm)]

On Thu, Oct 22, 2009 at 9:14 AM, Craig Hewetson <email address hidden> wrote:
> Well test the no-graph option soon

no-graph won't make a difference.

[Craig Hewetson (craighewetson-deactivatedaccount)]

Isn't there a platform specific set of colors for the text foreground when
selected?
What is the default colors used by the pyqt's table?

[Alexander Belchenko (bialix)]

Gary van der Merwe пишет:
> P.s. This bug can also be seen here:
> http://1.bp.blogspot.com/_ulqEWRozxIE/StdFMdOCwjI/AAAAAAAAAAc/VtRwBFl-
> HtE/s1600-h/2.0.1and2.1.0b1.png

Yep, the text is white on light blue background.

[Craig Hewetson (craighewetson-deactivatedaccount)]

If custom colours are used, this is going to continue to be a problem when
people use different themes.

[Gary van der Merwe (garyvdm)]

It seems the QWindowsVistaStyle alters it's pallet just before it paints.
see http://qt4-x11.sourcearchive.com/documentation/4.5.1-2/qwindowsvistastyle_8cpp-source.html , search for CE_ItemViewItem

Unfortunately there is no way that we can just reuse that code. We will have to put in a specific check for vista, and reproduce that code.

[Gary van der Merwe (garyvdm)]

On Thu, Oct 22, 2009 at 9:30 AM, Craig Hewetson <email address hidden> wrote:
> If custom colours are used, this is going to continue to be a problem when
> people use different themes.

What makes you think that custom colors are use. Please read the
source code before you make statements like that.