revert should clear saved commit data.

[Gary van der Merwe]

If I do bzr revert, it is *very* unlikely that I'm going to use the saved commit data, either from uncommit, or from canceling a qcommit dialog. Hence, bzr revert should clear the data.

[Lukáš Lalinský (luks)]

Same for switch, but I doubt there is a hook for that.

[Gary van der Merwe (garyvdm)]

2009/9/15 Lukáš Lalinský <email address hidden>:
> Same for switch, but I doubt there is a hook for that.

Switch will merge the uncommitted changes in the working tree with the
branch you are switching to, so the save commit data will still be
relevant.

[Alexander Belchenko (bialix)]

There is possible 2 cases for revert:

1) revert entire tree + pending merges
2) selective revert

I think in the case 1 saved commit data is no more relevant. But in the case of 2 it's not clear what is right thing.

[Alexander Belchenko (bialix)]

Gary, is there any hook in bzr that will be invoked at revert command? I don't see any one.

I can provide fix when we run qrevert, but I don't see a sane way to do in plain revert.
Overloading std revert command is bad approach as we learn from merge --qpreview.

Thoughts?

[Alexander Belchenko (bialix)]

About switch: as part of new commit_data approach we save old_revid/new_revid pair. We can use new_revid value to check that user trying to commit a tree from new_revid revision. If it's not then we can throw away saved commit_data.

Lukas, what do you think?