qswitch crashes if there is an 'unknown format' branch

[John A Meinel]

I don't think this is generic to 'qswitch', but when I bring up "bzr qswitch" it starts churning something on my hard drive (presumably looking for branches.)

It then runs into a Loom branch that I created a while ago, but have since removed bzr-loom.

After spinning for a while, it just disappears, and I see:
% bzr qswitch
bzr: ERROR: Unknown branch format: 'Bazaar-NG Loom branch format 6\n'

Potentially this is just something down at the bzr "Repository.branches?" layer. Though it would be good for qswitch to catch the "NotBranch" error and/or "UnknownFormat" errorr and continue operating, rather than having the window die.

[Alexander Belchenko (bialix)]

John, will be nice to have traceback.

I suppose it dies on the following code in lib/switch.py:

        repo = self.branch.bzrdir.find_repository()

        if repo != None:
            branches = repo.find_branches() # <<<<< Perhaps here?
            for br in branches:
                branch_combo.addItem(url_for_display(br.base))

As I could see this error comes from bzrlib internals. So the best we can do is to catch error here (which error exactly? traceback?) and leaves branches empty list.

Do you agree?