qcommit dialog needs some ui attention.

[Gary van der Merwe]

There are some small qcommit irritating ui bugs that need to be ironed out.

* Pressing Esc or Enter does not accept/reject. (Ctrl-Enter still works if you are on the message edit box.)
* The tab order does not follow the layout.

[Alexander Belchenko (bialix)]

AFAIK Esc/Enter are working now because qcommit is based on QBzrDialog window class.

[Craig Hewetson (craighewetson-deactivatedaccount)]

Comments from qbzr mailing list, some ideas on how to improve the qcommit dialog:
1) Add option to tag a revision.
2) Remove checkbox from fixes
3) Remove checkbox from author
4) Change Author textbox to a combo-textbox, (There by easily changing between previously used authors)

Something that might need some thought:
Allow author text box to handle multiple authors, separated by semi-colon.

Attached a mockup.

[Gary van der Merwe (garyvdm)]

I think it would make sense to have tag, and fixes next to each other.
To do this, lets move author up above fixes.

[Alexander Belchenko (bialix)]

Gary van der Merwe пишет:
> I think it would make sense to have tag, and fixes next to each other.
> To do this, lets move author up above fixes.

Why you think this is mandatory? IMO Craig mockup shows this is possible to achieve in existing
sequence of controls too.

[Alexander Belchenko (bialix)]

Copied from ML:

OK, now is my chance for make proposal about qcommit changes.

1) I want to add combobox above message text area to select one of latest 10 (?) committed messages.
I've used this feature in TortoiseCVS and like it.

2) Somebody (Russel? Nick?) asked about adding diff view to the qcommit.

3) Lukas want to get rid of help message from Branch group box when there is bound branch and local
commit in actions.

4) I want to rework Branch group box so it will show tree base for light checkout + master branch,
bound to branch root + master branch, or just standalone tree root. So in several cases there would
be 2 lines of locations, and local commit checkbox will be 3rd. Is it good? Or everybody used to
current behavior?

5) I want to automatically or via options in qbzr.conf adjust the size and layout of controls in
qcommit to support small-sized netbooks.

[Craig Hewetson (craighewetson-deactivatedaccount)]

Just adding the other mockup, so that we can refer to it.

[Gary van der Merwe (garyvdm)]

On Thu, Aug 27, 2009 at 6:27 AM, Alexander Belchenko<email address hidden> wrote:
> Gary van der Merwe пишет:
>> I think it would make sense to have tag, and fixes next to each other.
>> To do this, lets move author up above fixes.
>
> Why you think this is mandatory? IMO Craig mockup shows this is possible to achieve in existing
> sequence of controls too.

Not mandatory. Just a small ui nit pick.

[Alexander Belchenko (bialix)]

Gary van der Merwe пишет:
> On Thu, Aug 27, 2009 at 6:27 AM, Alexander Belchenko<email address hidden> wrote:
>> Gary van der Merwe пишет:
>>> I think it would make sense to have tag, and fixes next to each other.
>>> To do this, lets move author up above fixes.
>> Why you think this is mandatory? IMO Craig mockup shows this is possible to achieve in existing
>> sequence of controls too.
>
> Not mandatory. Just a small ui nit pick.

This change will break TAB navigation.

Today user can enter commit message, TAB and enter bug number.

With your proposed change he should TAB twice.

[Craig Hewetson (craighewetson-deactivatedaccount)]

IMO authors gets change less often (and besides it can always show the
previously specified author as default.) and therefore it would make sense
to be placed below the fixes and tag text boxes.

[Gary van der Merwe (garyvdm)]

On Thu, Aug 27, 2009 at 9:37 AM, Alexander Belchenko<email address hidden> wrote:
>
> This change will break TAB navigation.
>
> Today user can enter commit message, TAB and enter bug number.
>
> With your proposed change he should TAB twice.

Ok. We could have:

Fixes
Tag
Author

or as Craig has it in his second screen shot

Fixes Tag
Author

[Alexander Belchenko (bialix)]

Gary van der Merwe пишет:
> On Thu, Aug 27, 2009 at 9:37 AM, Alexander Belchenko<email address hidden> wrote:
>> This change will break TAB navigation.
>>
>> Today user can enter commit message, TAB and enter bug number.
>>
>> With your proposed change he should TAB twice.
>
> Ok. We could have:
>
> Fixes
> Tag
> Author
>
>
> or as Craig has it in his second screen shot
>
> Fixes Tag
> Author
>

I think the latter will be OK.

[Craig Hewetson (craighewetson-deactivatedaccount)]

I'm keen either way, but if there are more controls introduced by the 5
points list by Alexander then maybe the
Fixes Tag
Author

approach might save space.