Add qdiff pane to the qcommit window

[Russ Brown]

Add a qdiff pane to the qcommit window which shows the diff of the selected file in the file list. This will make previewing changes prior to commit much quicker (saving on opening and closing a diff window for each file).

[Alexander Belchenko (bialix)]

I don't think pane or tab(?) is good. I'd like to see "Diff" button in bottom left corner as qlog has.

[Russ Brown (pickscrape)]

A button wouldn't be much different from being able to double-click the file to see the diff, which qcommit already has.

qcommit to me appears to have a lot of available space in its window. It opens up with the message box absolutely huge, when much of the time a commit message consists of only a few lines. I often find myself having to resize the file list pane so I can see all of the files at once. Adding a diff pane would for me be a far better (and more productive) use of that space.

So, when committing and reviewing, instead of going:

 1. Double click file
 2. Wait for qdiff window to fire up
 3. Review in new window
 4. Close window
 5. Repeat for each file

You just have to do this:

 1. Click file
 2. Review in diff pane
 3. Repeat for each file

[Alexander Belchenko (bialix)]

Russ Brown пишет:
> A button wouldn't be much different from being able to double-click the
> file to see the diff, which qcommit already has.

Well, when I said about Diff button I mean viewing diff for all files
selected to commit. I found looking at one file diff very often useless,
especially for C-projects where changes in code and headers come together.

[Gary van der Merwe (garyvdm)]

I don't think this should be done.

I do think we should have a diff button to get to a diff of all file. I'm going to log a new bug for that.

[Russ Brown (pickscrape)]

:(

This for me would possibly be the single biggest boost to the usability of qcommit.

Being able click the file and see the diff without having to wait for another window to pop up, and then to be able to look at that diff in the same window that I am writing the comment in would be fantastic. Adding a button to show the complete diff only helps this case if the total diff is quite small (though it would be a useful feature in of itself too).

Oh well. :(

Not that I could do anything about this any time soon anyway, but would a patch to implement this be outright rejected?

[Gary van der Merwe (garyvdm)]

On Wed, May 27, 2009 at 3:39 PM, Russ Brown <email address hidden> wrote:
> Not that I could do anything about this any time soon anyway, but would
> a patch to implement this be outright rejected?

No.