qcommit: have no sense to allow revert or diff for non-versioned files

[Alexander Belchenko]

If user check option "Show non-versioned files" then it possible to right-click on unversioned file and invoke revert or diff command. It's absolutely have no sense. But in the case of revert qcommit correctly shows error dialog with message "Path(s) not versioned", but in the case of diff internal bzrlib errors stays unhandled and produce traceback in console:

Traceback (most recent call last):
  File "C:\work\Bazaar\plugins-repo\qbzr\commit.py", line 469, in show_differences
    branch=self.tree.branch)
  File "C:\work\Bazaar\plugins-repo\qbzr\diff.py", line 312, in __init__
    treediff = TreeDiff(self.tree1, self.tree2, self.specific_files, complete)
  File "C:\work\Bazaar\plugins-repo\qbzr\diff.py", line 236, in __init__
    self._make_diff(old_tree, new_tree, specific_files, complete)
  File "C:\work\Bazaar\plugins-repo\qbzr\diff.py", line 189, in _make_diff
    delta = new_tree.changes_from(old_tree, specific_files=specific_files, require_versioned=True)
  File "bzrlib\tree.pyc", line 93, in changes_from
  File "bzrlib\decorators.pyc", line 127, in read_locked
  File "bzrlib\tree.pyc", line 633, in compare
  File "bzrlib\workingtree_4.pyc", line 900, in paths2ids
  File "bzrlib\workingtree_4.pyc", line 948, in _paths2ids_in_memory
bzrlib.errors.PathsNotVersionedError: Path(s) are not versioned: uninst.exe

[Alexander Belchenko (bialix)]

May be instead for non-versioned files right-click menu should suggest add?

[Lukáš Lalinský (luks)]

Just a note that 'Add' context menu is useless, because qcommit will add non-versioned with checked check-box automatically.

[Alexander Belchenko (bialix)]

Lukáš Lalinský пишет:
> Just a note that 'Add' context menu is useless, because qcommit will add
> non-versioned with checked check-box automatically.

Yeah, I saw it, but it's magic behavior, although it's correct, and
therefore could be unclear for new users.

But traceback on revert should be fixed anyway, IMO.