qcommit forces a commit message

Bug #1053285 reported by Stefan Wieser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Confirmed
Low
Unassigned

Bug Description

Committing with Tortoise Bazaar 0.6.6 forces the user to enter a commit message, which is not even required by Bazaar itself (https://bugs.launchpad.net/bzr/+bug/172506). It seems to be reasonable to bring the behaviour of Tortoise Bazaar in line with Bazaar, so both tools behave identically.

Furthermore, the error message is poorly worded. It reads "You should provide a commit message." when entering a commit message is an outright requirement. The correct wording would be "Bazaar requires that you enter a commit message." - which is outdated, however, since Bazaar no longer does.

Tags: qcommit
Revision history for this message
Alexander Belchenko (bialix) wrote :

I don't know when bzr changed its behavior re empty commit message. We can change that behavior in qcommit dialog however.
If somebody wants to provide a patch I can give a hint: qbzr/lib/commit.py method validate does that check. Method do_start creates command line for bzr commit. There should be created some hack to create `bzr commit -m ""` command-line, perhaps additional change to qbzr\lib\subprocess.py is required.
Patches are welcome!

affects: tortoisebzr → qbzr
Changed in qbzr:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Alexander Belchenko (bialix) wrote :

Probably the best way is to create command-line as `bzr commit --message=` that does the trick. Then no changes to qbzr\lib\subprocess.py will be required.

summary: - Commit forces a commit message
+ qcommit forces a commit message
tags: added: qcommit
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.