BzrMoveFailedError when a file is moved to an unversioned directory

[André Bachmann]

The problem occurs with plain Bazaar 2.5.1 on Windows 7 x64 and also on Linux:

I opened a folder with a bzr branch (qbzr) containing a working tree. Then I created a new directory "test2" (which is obviously listed as unversioned). Now I move an already versioned file to this new directory. An BzrMoveFailedError happens:

Tue 2012-08-21 15:31:31 +0200
0.050 bazaar version: 2.5.1
0.051 bzr arguments: [u'mv', u'AUTHORS.txt', u'test2']
0.051 looking for plugins in C:/Users/bachmann/AppData/Roaming/bazaar/2.0/plugins
0.056 looking for plugins in C:/Program Files (x86)/Bazaar/plugins
0.056 Plugin name bzrtools already loaded
0.056 Plugin name explorer already loaded
0.057 Plugin name qbzr already loaded
0.057 Plugin name rewrite already loaded
0.081 encoding stdout as sys.stdout encoding 'cp850'
0.102 opening working tree 'C:/spielwiese/testing/qbzr'
0.125 Transferred: 0kB (0.0kB/s r:0kB w:0kB)
0.125 Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 920, in exception_to_return_code
  File "bzrlib\commands.pyo", line 1131, in run_bzr
  File "bzrlib\commands.pyo", line 673, in run_argv_aliases
  File "bzrlib\commands.pyo", line 695, in run
  File "bzrlib\cleanup.pyo", line 136, in run_simple
  File "bzrlib\cleanup.pyo", line 166, in _do_with_cleanups
  File "bzrlib\builtins.pyo", line 1024, in run
  File "bzrlib\builtins.pyo", line 1063, in _run
  File "bzrlib\mutabletree.pyo", line 52, in tree_write_locked
  File "bzrlib\workingtree_4.pyo", line 667, in move
BzrMoveFailedError: Could not move to test2: test2 is not versioned.

0.126 return code 3

This is especially a problem because qbzr catches this exception and shows this to the user. However, this is an issue with bzrlib, so it should be fixed here.

[Martin Packman (gz)]

This is a reasonable error on the command line, and appears as other probably-user-errors do:

    $ bzr mv f d
    bzr: ERROR: Could not move to d: d is not versioned.

So, I think qbzr just needs to grow handling for it. What would the behaviour be otherwise? Automatically version 'd'? That's also surprising in several circumstances.

[Alexander Belchenko (bialix)]

The best thing qbzr could do is to provide a nice message box rather than throwing an error to user.