qdiff on dark KDE theme: better discovery of colors configuration needed

[Marcin Wojdyr]

I'm using Fedora 17, KDE and Slim Glow theme.
qdiff is not readable in normal mode, the only way to read it is to switch to Unidiff.
I think it's different issue than #592403
Screenshot attached.

[Alexander Belchenko (bialix)]

bug 592403

[Alexander Belchenko (bialix)]

Please, see https://bugs.launchpad.net/qbzr/+bug/280041/comments/4
Yi=ou should be able to specify new colors to make them more readable.

[Alexander Belchenko (bialix)]

Tell us whether it helps you.

[Marcin Wojdyr (wojdyr)]

Thanks, it helped. It seams that "COLOURS" and "replacement_text_background" have been renamed since that comment, but finally I got readable diff.
Here is what I added to ~/.bazaar/qbzr.conf

[QDIFF COLORS]
delete_fill = 33, 22, 22
delete_bound = 99, 66, 66
insert_fill = 22, 33, 22
insert_bound = 66, 99, 66
replace_fill = 22, 22, 33
replace_bound = 66, 66, 99
blank_fill = 99, 99, 99
blank_bound = 99, 99, 99
interline_changes_background = 0, 0, 0

I'm closing it, but it would be nice to have GUI for color configuration, or at least a hint that it's possible.

[Alexander Belchenko (bialix)]

Marcin Wojdyr пишет:
> Thanks, it helped. It seams that "COLOURS" and "replacement_text_background" have been renamed since that comment, but finally I got readable diff.
> Here is what I added to ~/.bazaar/qbzr.conf

Yep.

> I'm closing it, but it would be nice to have GUI for color
> configuration, or at least a hint that it's possible.

Do you have any suggestion how to best do it?

Maybe we should just add a knob to qconfig/GUI tab to switch between
dark theme and light theme? We can provide a hint about colors
configuration there as well. What do you think?

Would you like to prepare a patch?

--
All the dude wanted was his rug back

[Marcin Wojdyr (wojdyr)]

On 18 June 2012 08:33, Alexander Belchenko <email address hidden> wrote:
>> I'm closing it, but it would be nice to have GUI for color
>> configuration, or at least a hint that it's possible.
>
> Do you have any suggestion how to best do it?
>
> Maybe we should just add a knob to qconfig/GUI tab to switch between
> dark theme and light theme? We can provide a hint about colors
> configuration there as well. What do you think?

Actually I don't know what is " qconfig/GUI tab".
For me it would be easiest to find any options in the "View Options"
menu in "bzr qdiff" window.

Ideally resonable default colors were determined automatically, but I
don't know if that's possible.

>
> Would you like to prepare a patch?

no, sorry

[Alexander Belchenko (bialix)]

Marcin Wojdyr пишет:
> On 18 June 2012 08:33, Alexander Belchenko <email address hidden> wrote:
>>> I'm closing it, but it would be nice to have GUI for color
>>> configuration, or at least a hint that it's possible.
>> Do you have any suggestion how to best do it?
>>
>> Maybe we should just add a knob to qconfig/GUI tab to switch between
>> dark theme and light theme? We can provide a hint about colors
>> configuration there as well. What do you think?
>
> Actually I don't know what is " qconfig/GUI tab".

Run `bzr qconfig` then navigate to `User Interface` tab.

> For me it would be easiest to find any options in the "View Options"
> menu in "bzr qdiff" window.

OK, that makes sense. I'll investigate that.

> Ideally resonable default colors were determined automatically, but I
> don't know if that's possible.

I don't know either, and I don't have KDE.