turn off "Exchange trackers with other peers" feature by default

[Vladimir Lushpenko]

imho this is very dangerous feature. i often download torrents from private trackers, and every time i meet another libtorrent-based client with this feature turned on, i provide my tracker (with my passkey) to him, and his statistic starts going into my account. because of this feature qBittorrent was banned recently at largest russian tracker rutracker.org

i don't think this feature is actually usefull - it just duplicates PEX and DHT functional. but the worst is that i haven't even known about it, i just didn't pay much attention to strange traffic in my account - until qbittorrent got a ban at tracker :(

[Christophe Dumez (hydr0g3n)]

We have already checked that the trackers don't get exchanged if the torrents are marked as Private (DHT is also disabled in this case). Therefore, torrents issued by private trackers are not an issue (unless they don't set the 'Private' flag, but then it's their own mistake).

[Vladimir Lushpenko (vladimir-lushpenko)]

yes, they don't add 'private' flag. and actually i haven't seen any tracker which does this - it is strange, but it is a fact

well, if this is your point - okay then. but this will just lead to the situation, that qbittorrent will be banned on more and more trackers, where users have their own accounts and tracker does not force 'private' flag

[Christophe Dumez (hydr0g3n)]

Yes, this is my decision. I am not going to disable a useful feature to most users to support a few broken private trackers. Quite frankly, then the next step would be to disable DHT. If they don't set the private flag, then the private torrents are shared via DHT by default...

[Vladimir Lushpenko (vladimir-lushpenko)]

do you honestly believe this feature is that useful? DHT is a part of bittorrent protocol, and everyone knows about it. if private tracker allows non-private torrent, maybe they have some reasons to do that (and sure they know about DHT and PEX). meanwhile this "Exchange trackers with other peers"-feature is libtorrent-specific, nobody has any idea about it. from the end-user's point it looks just as qbittorrent stoles his passkey, while in any other bittorrent client everything works fine

ok, nevermind. just made a proposal