Search Engine (Improvement)

[Jürgen Heinemann (Undefined)]

I have modified source for better search optimization
This class provides a text based filter to QSortFilterProxyModel

@see qbittorrent-2.8.0-search-engine-filter.patch

mfg Undefined

[Christophe Dumez (hydr0g3n)]

Thanks a lot. I'll review it shortly.

[Christophe Dumez (hydr0g3n)]

This patch does not seem to work here (or I don't know how to use the new feature, which is bad too because it would mean it is not user-friendly).

1) I typed a search term in the engine and got a large number of results back. Your "search result optimization" box stays greyed out and there is no way for me to filter the result.

2) I don't really like the term "optimization". If I understand correctly "filtering" would be more adequate.

3) The UI interaction seems slightly complicated. It is difficult to say what they are meant for (also because they are disabled for me). The button on the left with label "> ...", by looking at it, I have no clue what it's meant for. And the spin box on the right with value "3", no clue either.

Please fix your patch so that I can at least test it. Also see if you can simplify the UI so that it is easier to use and so that it wastes less space.

Lastly, note that there is already a filtering box at the top right of the Windows. It is currently working for the transfer list only. However, I believe it would be nicer if you made it work for the search results too, instead of adding yet another widget to do the same thing.

[Jürgen Heinemann (Undefined) (juergen-heinemann)]

This patch exclude unfiltered large search results from QTreeView.
When QLineEdit::textChanged() emitted and the text.length() is greater then 3 it will send signal::searchTextChanged(data) otherwise an empty string is emitted by signal::searchTextChanged(QString()) and clear the QSortFilterProxyModel::sort() Model to display all original search results.

I have add this Widget to minimize the given Search result.

Your Search input at the top didn't work for me

mfg Undefined

[Christophe Dumez (hydr0g3n)]

> Your Search input at the top didn't work for me
Well, it doesn't, at least not for search. However, I would prefer if you made it work for search instead of adding a new search-specific widget.

[Jürgen Heinemann (Undefined) (juergen-heinemann)]

OK – I'm add my changes in a separate class with regular expression support
i hope you'll import this feature ;)